TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 17 Packages Activity Actions

[#507] Return not implemented by default in bucket router #508

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:feature/public_access_block into master 2024-10-07 05:38:36 +00:00
Conversation 0 Commits 1 Files changed 5 +116 -16
mbiryukova commented 2024-10-01 08:28:02 +00:00
Member
Copy link

Closes #507

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #507 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-10-01 08:28:02 +00:00
mbiryukova added 1 commit 2024-10-01 08:28:02 +00:00
[#507] Add routing for public access block operations
All checks were successful
/ DCO (pull_request) Successful in 1m12s
Details
/ Vulncheck (pull_request) Successful in 1m32s
Details
/ Builds (pull_request) Successful in 1m21s
Details
/ Lint (pull_request) Successful in 1m56s
Details
/ Tests (pull_request) Successful in 1m27s
Details
dbd0bc2252 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2024-10-01 08:32:16 +00:00
mbiryukova requested review from storage-services-developers 2024-10-01 08:32:16 +00:00
pogpp approved these changes 2024-10-01 09:25:30 +00:00
Dismissed
mbiryukova force-pushed feature/public_access_block from dbd0bc2252 to c1828e1654 2024-10-01 14:51:11 +00:00 Compare
mbiryukova dismissed pogpp's review 2024-10-01 14:51:11 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

mbiryukova changed title from [#507] Add routing for public access block operations to [#507] Return not implemented by default in bucket router 2024-10-01 14:53:44 +00:00
mbiryukova requested review from storage-services-committers 2024-10-01 14:53:57 +00:00
mbiryukova requested review from storage-services-developers 2024-10-01 14:53:57 +00:00
dkirillov reviewed 2024-10-02 06:38:23 +00:00
api/router.go Outdated
@ -229,0 +233,4 @@
_, wrErr := s3middleware.WriteErrorResponse(w, reqInfo, errors.GetAPIError(errors.ErrNotSupported))
if log := s3middleware.GetReqLog(ctx); log != nil {
dkirillov commented 2024-10-02 06:38:23 +00:00
Member
Copy link

It's better to log before writing response I suppose

It's better to log before writing response I suppose
👍 1
mbiryukova commented 2024-10-02 15:04:58 +00:00
Author
Member
Copy link

Should we log error from WriteErrorResponse in such case?

Should we log error from `WriteErrorResponse` in such case?
dkirillov commented 2024-10-03 06:31:39 +00:00
Member
Copy link

Oh, I see that we do the same in all other places. So just ignore my comment.

Oh, I see that we do the same in all other places. So just ignore my comment.
👀 1
dkirillov reviewed 2024-10-02 06:40:21 +00:00
api/router_filter.go Outdated
@ -123,2 +141,4 @@
LOOP:
for _, filter := range hf.filters {
if filter.noQueries && len(r.URL.Query()) > 0 {
continue LOOP
dkirillov commented 2024-10-02 06:40:21 +00:00
Member
Copy link

Can be just continue

Can be just `continue`
dkirillov approved these changes 2024-10-02 06:41:06 +00:00
Dismissed
mbiryukova force-pushed feature/public_access_block from c1828e1654 to 9c12888571 2024-10-03 09:05:23 +00:00 Compare
mbiryukova dismissed dkirillov's review 2024-10-03 09:05:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dkirillov approved these changes 2024-10-03 12:15:50 +00:00
alexvanin approved these changes 2024-10-07 05:38:29 +00:00
alexvanin merged commit 9e5fb4be95 into master 2024-10-07 05:38:36 +00:00
alexvanin deleted branch feature/public_access_block 2024-10-07 05:38:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#508
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/public_access_block"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?