TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#505] authmate: Add flag for headers in generate-presigned-url cmd #526

Merged
alexvanin merged 2 commits from mbiryukova/frostfs-s3-gw:feature/configure_content_type into master 2024-11-02 08:53:55 +00:00
Conversation 0 Commits 2 Files changed 3 +52 -2
mbiryukova commented 2024-10-29 15:12:01 +00:00
Member
Copy link

Closes #505

Closes #505
mbiryukova self-assigned this 2024-10-29 15:12:01 +00:00
mbiryukova added 2 commits 2024-10-29 15:12:02 +00:00 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
[#505] docs: Add example of uploading file using presigned URL
All checks were successful
/ DCO (pull_request) Successful in 1m13s
Details
/ Vulncheck (pull_request) Successful in 1m23s
Details
/ Builds (pull_request) Successful in 1m30s
Details
/ Lint (pull_request) Successful in 2m36s
Details
/ Tests (pull_request) Successful in 1m36s
Details
9ea3b00413 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2024-10-29 15:15:43 +00:00
mbiryukova requested review from storage-services-developers 2024-10-29 15:15:44 +00:00
dkirillov reviewed 2024-10-30 11:24:07 +00:00
cmd/s3-authmate/modules/generate-presigned-url.go Outdated
@ -36,6 +36,7 @@ const (
regionFlag = "region"
awsAccessKeyIDFlag = "aws-access-key-id"
awsSecretAccessKeyFlag = "aws-secret-access-key"
contentTypeFlag = "content-type"
dkirillov commented 2024-10-30 11:24:07 +00:00
Member
Copy link

It's better to use more general flag like header to be able to pass any headers we want

It's better to use more general flag like `header` to be able to pass any headers we want
dkirillov marked this conversation as resolved
mbiryukova force-pushed feature/configure_content_type from 9ea3b00413 to f94e1a3e12 2024-10-30 13:48:27 +00:00 Compare
mbiryukova changed title from [#505] authmate: Add flag for Content-Type header in generate-presigned-url cmd to [#505] authmate: Add flag for headers in generate-presigned-url cmd 2024-10-30 13:53:38 +00:00
dkirillov approved these changes 2024-10-31 06:30:24 +00:00
dkirillov left a comment
Member
Copy link

LGTM

LGTM
alexvanin approved these changes 2024-11-02 08:53:41 +00:00
alexvanin merged commit 17d40245de into master 2024-11-02 08:53:55 +00:00
alexvanin deleted branch feature/configure_content_type 2024-11-02 08:53:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#526
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/configure_content_type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?