TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#538] Return headers with 304 Not Modified #547

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:bugfix/not_modified into master 2024-11-13 13:49:10 +00:00
Conversation 0 Commits 1 Files changed 6 +116 -26
mbiryukova commented 2024-11-11 13:42:15 +00:00
Member
Copy link

Closes #538

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #538 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-11-11 13:42:15 +00:00
mbiryukova added 1 commit 2024-11-11 13:42:16 +00:00
[#538] Return headers with 304 Not Modified
All checks were successful
/ DCO (pull_request) Successful in 1m25s
Details
/ Vulncheck (pull_request) Successful in 1m32s
Details
/ Builds (pull_request) Successful in 1m49s
Details
/ Lint (pull_request) Successful in 2m57s
Details
/ Tests (pull_request) Successful in 1m53s
Details
e1054917ec 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-services-committers 2024-11-11 13:45:51 +00:00
mbiryukova requested review from storage-services-developers 2024-11-11 13:45:52 +00:00
dkirillov reviewed 2024-11-12 06:47:13 +00:00
api/handler/get.go
@ -81,0 +81,4 @@
func writeNotModifiedHeaders(h http.Header, extendedInfo *data.ExtendedObjectInfo, tagSetLength int, isBucketUnversioned, md5Enabled bool) {
h.Set(api.ETag, data.Quote(extendedInfo.ObjectInfo.ETag(md5Enabled)))
h.Set(api.LastModified, extendedInfo.ObjectInfo.Created.UTC().Format(http.TimeFormat))
h.Set(api.AmzTaggingCount, strconv.Itoa(tagSetLength))
dkirillov commented 2024-11-12 06:47:13 +00:00
Member
Copy link

Why do we need other headers except ETag and Last-Modified?

Why do we need other headers except `ETag` and `Last-Modified`?
mbiryukova commented 2024-11-12 10:07:53 +00:00
Author
Member
Copy link

I checked what aws returns in such cases

I checked what aws returns in such cases
dkirillov marked this conversation as resolved
alexvanin approved these changes 2024-11-12 12:57:36 +00:00
dkirillov approved these changes 2024-11-13 11:30:23 +00:00
alexvanin merged commit eff0de43d5 into master 2024-11-13 13:49:10 +00:00
alexvanin deleted branch bugfix/not_modified 2024-11-13 13:49:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
dkirillov
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#547
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:bugfix/not_modified"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?