TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 7 Projects Releases 18 Packages Activity Actions

[#553] authmate: Don't use basic acl #554

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:featue/553-dont_use_basic_acl into master 2024-11-20 15:43:56 +00:00
Conversation 0 Commits 1 Files changed 2 +98 -4
dkirillov commented 2024-11-18 12:31:45 +00:00
Member
Copy link

close #553

close #553
dkirillov self-assigned this 2024-11-18 12:31:45 +00:00
dkirillov added 1 commit 2024-11-18 12:31:45 +00:00
[#553] authmate: Don't use basic acl
All checks were successful
/ DCO (pull_request) Successful in 1m44s
Details
/ Vulncheck (pull_request) Successful in 2m8s
Details
/ Builds (pull_request) Successful in 2m27s
Details
/ Lint (pull_request) Successful in 3m45s
Details
/ Tests (pull_request) Successful in 2m42s
Details
a45bbe9c14 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed featue/553-dont_use_basic_acl from a45bbe9c14 to 4253fc5b90 2024-11-18 12:32:20 +00:00 Compare
dkirillov added 1 commit 2024-11-19 08:22:48 +00:00
[#553] authmate: Add retryer to create access box
All checks were successful
/ DCO (pull_request) Successful in 1m28s
Details
/ Vulncheck (pull_request) Successful in 1m45s
Details
/ Builds (pull_request) Successful in 1m48s
Details
/ Lint (pull_request) Successful in 2m23s
Details
/ Tests (pull_request) Successful in 1m49s
Details
ed4cc417b7 
After using AddChain to provide access to container we have to wait:
* tx with APE chain be accepted by blockchain
* cache in storage node be updated

it takes a while. So we add retry
 (the same as when we add bucket settings during bucket creation)

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov changed title from WIP: [#553] authmate: Don't use basic acl to [#553] authmate: Don't use basic acl 2024-11-19 08:23:04 +00:00
dkirillov requested review from storage-services-developers 2024-11-19 08:23:12 +00:00
dkirillov requested review from storage-services-committers 2024-11-19 08:23:17 +00:00
alexvanin reviewed 2024-11-19 12:02:18 +00:00
api/layer/frostfs/frostfs.go Outdated
@ -47,1 +44,4 @@
type PrmAddContainerPolicyChain struct {
ContainerID cid.ID
Chain chain.Chain
alexvanin commented 2024-11-19 11:48:18 +00:00
Owner
Copy link

Don't you want to add comments like in other param structs?

Don't you want to add comments like in other param structs?
dkirillov commented 2024-11-19 12:06:08 +00:00
Author
Member
Copy link

Sure

Sure
internal/frostfs/authmate.go Outdated
@ -73,0 +84,4 @@
Op: chain.CondStringEquals,
Kind: chain.KindRequest,
Key: native.PropertyKeyActorPublicKey,
Value: hex.EncodeToString(prm.Owner.Bytes()),
alexvanin commented 2024-11-19 12:02:14 +00:00
Owner
Copy link

Do we need explicit allow rule for container owner? As far as I understand, we can use frostfs-cli to create container and then upload object without additional APEs

Do we need explicit allow rule for container owner? As far as I understand, we can use frostfs-cli to create container and then upload object without additional APEs
dkirillov commented 2024-11-19 12:11:31 +00:00
Author
Member
Copy link

Yes, we have to add explicit rule for container owner. We will create AccessBox there and we need access.

Yes, we have to add explicit rule for container owner. We will create AccessBox there and we need access.
alexvanin marked this conversation as resolved
internal/frostfs/frostfs.go Outdated
@ -138,0 +138,4 @@
// AddContainerPolicyChain implements frostfs.FrostFS interface method.
func (x *FrostFS) AddContainerPolicyChain(ctx context.Context, prm frostfs.PrmAddContainerPolicyChain) error {
var prmAddAPEChain pool.PrmAddAPEChain
prmAddAPEChain.Target = ape.ChainTarget{
alexvanin commented 2024-11-19 11:55:41 +00:00
Owner
Copy link

According to internal code style, could you remind me, do we prefer such var definition or use := straight away?

According to internal code style, could you remind me, do we prefer such `var` definition or use `:=` straight away?
dkirillov commented 2024-11-19 12:06:47 +00:00
Author
Member
Copy link

Oh, I just extended your branch. I'll fix style

Oh, I just extended your branch. I'll fix style
🎉 1
alexvanin marked this conversation as resolved
dkirillov force-pushed featue/553-dont_use_basic_acl from ed4cc417b7 to dce34ddb9b 2024-11-19 12:12:11 +00:00 Compare
dkirillov force-pushed featue/553-dont_use_basic_acl from dce34ddb9b to b1775f9478 2024-11-19 12:46:10 +00:00 Compare
alexvanin approved these changes 2024-11-19 14:49:11 +00:00
alexvanin merged commit b1775f9478 into master 2024-11-20 08:13:11 +00:00
alexvanin deleted branch featue/553-dont_use_basic_acl 2024-11-20 08:13:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#554
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:featue/553-dont_use_basic_acl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?