[#502] Add Dropped logs (by sampling) metric #557

pogpp · 2024-11-20T12:06:05Z

pogpp commented

2024-11-20 12:06:05 +00:00

close #502
Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

close #502 Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>

pogpp added 1 commit 2024-11-20 12:06:06 +00:00

[#502 ] Add Dropped logs (by sampling) metric

/ DCO (pull_request) Successful in 2m26s

Details

/ Vulncheck (pull_request) Successful in 2m27s

Details

/ Builds (pull_request) Successful in 2m36s

Details

/ Lint (pull_request) Successful in 2m30s

Details

/ Tests (pull_request) Successful in 2m9s

Details

80afebff7a

Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>

pogpp requested review from alexvanin 2024-11-20 12:06:33 +00:00

pogpp requested review from dkirillov 2024-11-20 12:06:33 +00:00

pogpp requested review from mbiryukova 2024-11-20 12:06:35 +00:00

pogpp requested review from r.loginov 2024-11-20 12:06:36 +00:00

pogpp requested review from nzinkevich 2024-11-20 12:06:37 +00:00

pogpp force-pushed feature/502_sampling_metric from 80afebff7a to b5eb8d185d

2024-11-20 12:07:21 +00:00

Compare

pogpp self-assigned this 2024-11-20 12:10:47 +00:00

dkirillov reviewed 2024-11-21 06:57:56 +00:00

metrics/app.go Outdated

					
				@ -43,2 +43,4 @@

				}

				func (m *AppMetrics) DroppedLogsInc() {

					m.gate.Logs.DroppedLogsInc()

dkirillov commented

2024-11-21 06:57:53 +00:00

Please, use approach as for UsersAPIStats or APIStatMetrics or StateMetrics

Please, use approach as for `UsersAPIStats` or `APIStatMetrics` or `StateMetrics`

pogpp force-pushed feature/502_sampling_metric from b5eb8d185d to 26e5be8918

2024-11-21 10:29:36 +00:00

Compare

/ DCO (pull_request) Successful in 1m33s

Details

/ Vulncheck (pull_request) Successful in 1m53s

Details

/ Builds (pull_request) Successful in 1m58s

Details

/ Lint (pull_request) Successful in 2m26s

Details

/ Tests (pull_request) Successful in 1m58s

Details

This pull request doesn't have enough approvals yet. 0 of 2 approvals granted.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u feature/502_sampling_metric:pogpp-feature/502_sampling_metric

git checkout pogpp-feature/502_sampling_metric

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#557