TrueCloudLab/frostfs-s3-gw
18
3
Fork 20
Code Issues 29 Pull requests 8 Projects Releases 23 Packages Activity Actions

[#577] Update SDK to support new tree/pool version #577

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-s3-gw:feature/update_sdk into master 2024-12-20 11:36:24 +00:00
Conversation 0 Commits 1 Files changed 21 +371 -124
mbiryukova commented 2024-12-12 10:29:52 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-12-12 10:29:52 +00:00
mbiryukova added 1 commit 2024-12-12 10:29:53 +00:00
[#xxx] Update SDK to support new tree/pool version
Some checks failed
/ Builds (pull_request) Successful in 2m17s
Details
/ DCO (pull_request) Failing after 3m26s
Details
/ Vulncheck (pull_request) Successful in 3m33s
Details
/ Lint (pull_request) Successful in 4m1s
Details
/ Tests (pull_request) Successful in 2m20s
Details
8c362d8c0e 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova force-pushed feature/update_sdk from 8c362d8c0e to aacace4bba 2024-12-12 10:30:25 +00:00 Compare
mbiryukova changed title from WIP: [#xxx] Update SDK to support new tree/pool version to WIP: [#577] Update SDK to support new tree/pool version 2024-12-12 10:31:49 +00:00
alexvanin added this to the v0.32.0 milestone 2024-12-13 11:25:43 +00:00
mbiryukova force-pushed feature/update_sdk from aacace4bba to dd96708a9d 2024-12-16 09:27:53 +00:00 Compare
mbiryukova force-pushed feature/update_sdk from dd96708a9d to 22c290fec4 2024-12-16 09:45:54 +00:00 Compare
alexvanin reviewed 2024-12-16 12:36:26 +00:00
docs/configuration.md Outdated
@ -688,12 +688,14 @@ features:
deny_by_default: false
md5:
enabled: false
tree_pool_v2: true
alexvanin commented 2024-12-16 12:13:10 +00:00
Owner
Copy link

Let's use something more self-explained, e.g. tree_pool_netmap_support: true or something like this.

Let's use something more self-explained, e.g. `tree_pool_netmap_support: true` or something like this.
👍 1
alexvanin marked this conversation as resolved
internal/frostfs/source.go Outdated
@ -0,0 +52,4 @@
prm.SessionToken = bd.Gate.SessionToken()
}
res, err := n.frostFS.Container(ctx, prm)
alexvanin commented 2024-12-16 12:10:57 +00:00
Owner
Copy link

By the way, it would be very interesting to find out amount of cache misses during S3 load. Maybe we can prepare some custom build and make some load tests to see, if cache misses ever happen or not.

By the way, it would be very interesting to find out amount of cache misses during S3 load. Maybe we can prepare some custom build and make some load tests to see, if cache misses ever happen or not.
internal/frostfs/source.go Outdated
@ -0,0 +56,4 @@
if err != nil {
return netmap.PlacementPolicy{}, fmt.Errorf("get container: %w", err)
}
alexvanin commented 2024-12-16 12:09:45 +00:00
Owner
Copy link
// We don't put container back to the cache to keep cache
// coherent to the requests made by S3 users. FrostFS Source
// is being used by SDK Tree Pool and it should not fill cache
// with possibly irrelevant container values.
``` // We don't put container back to the cache to keep cache // coherent to the requests made by S3 users. FrostFS Source // is being used by SDK Tree Pool and it should not fill cache // with possibly irrelevant container values. ```
👍 1
alexvanin marked this conversation as resolved
mbiryukova force-pushed feature/update_sdk from 22c290fec4 to 125a341d27 2024-12-17 05:27:59 +00:00 Compare
mbiryukova force-pushed feature/update_sdk from 125a341d27 to 18e0db4b4b 2024-12-18 08:22:41 +00:00 Compare
mbiryukova force-pushed feature/update_sdk from 18e0db4b4b to 14162d8911 2024-12-18 08:35:58 +00:00 Compare
mbiryukova changed title from WIP: [#577] Update SDK to support new tree/pool version to [#577] Update SDK to support new tree/pool version 2024-12-18 08:41:12 +00:00
mbiryukova requested review from storage-services-committers 2024-12-18 08:41:12 +00:00
mbiryukova requested review from storage-services-developers 2024-12-18 08:41:12 +00:00
mbiryukova force-pushed feature/update_sdk from 14162d8911 to fe1ac463d0 2024-12-19 11:01:38 +00:00 Compare
alexvanin approved these changes 2024-12-19 14:36:57 +00:00
Dismissed
dkirillov reviewed 2024-12-20 06:37:14 +00:00
docs/configuration.md Outdated
@ -450,3 +450,3 @@
lifetime: 1m
size: 10000
network_info:
network:
dkirillov commented 2024-12-20 06:37:14 +00:00
Member
Copy link

Is it ok to change old params just in one release?
@alexvanin

Is it ok to change old params just in one release? @alexvanin
alexvanin commented 2024-12-20 10:40:48 +00:00
Owner
Copy link

Yeah, let's not do that, I suppose. That's not a great naming but it's better than breaking compaitbility.

Yeah, let's not do that, I suppose. That's not a great naming but it's better than breaking compaitbility.
alexvanin marked this conversation as resolved
dkirillov reviewed 2024-12-20 06:56:30 +00:00
api/cache/network.go Outdated
@ -0,0 +65,4 @@
return c.cache.Set(networkInfoKey, info)
}
func (c *NetworkCache) GetNetMap() *netmap.NetMap {
dkirillov commented 2024-12-20 06:40:56 +00:00
Member
Copy link

Can we write Netmap rather than NetMap? It seems in storage node there was a discussion on this topic

Can we write `Netmap` rather than `NetMap`? It seems in storage node there was a discussion on this topic
dkirillov approved these changes 2024-12-20 06:56:42 +00:00
Dismissed
mbiryukova force-pushed feature/update_sdk from fe1ac463d0 to 95d847d611 2024-12-20 10:52:37 +00:00 Compare
mbiryukova dismissed alexvanin's review 2024-12-20 10:52:38 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

mbiryukova dismissed dkirillov's review 2024-12-20 10:52:38 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexvanin approved these changes 2024-12-20 11:35:53 +00:00
alexvanin merged commit 95d847d611 into master 2024-12-20 11:36:24 +00:00
alexvanin deleted branch feature/update_sdk 2024-12-20 11:36:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.32.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#577
No description provided.
Delete branch "mbiryukova/frostfs-s3-gw:feature/update_sdk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?