TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 25 Pull requests 6 Projects Releases 24 Packages 1 Activity Actions

bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 #584

Merged
alexvanin merged 4 commits from r.loginov/frostfs-s3-gw:bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error into support/v0.31 2024-12-17 12:38:06 +00:00
Conversation 1 Commits 4 Files changed 14 +167 -37
r.loginov commented 2024-12-16 08:00:16 +00:00
Member
Copy link

close #583
close #586

close #583 close #586
r.loginov self-assigned this 2024-12-16 08:00:16 +00:00
r.loginov added 2 commits 2024-12-16 08:00:16 +00:00 
A situation may occur when the global
domain is already occupied when
creating the container. The error
comes from the nns smart contract.
This error actually means that the
bucket has already been created.

Signed-off-by: Roman Loginov <r.loginov@yadro.com>
[#583] Fix list-buckets vhs routing
Some checks failed
/ DCO (pull_request) Failing after 6m50s
Details
/ Vulncheck (pull_request) Successful in 7m14s
Details
/ Builds (pull_request) Successful in 2m15s
Details
/ Lint (pull_request) Successful in 2m57s
Details
/ Tests (pull_request) Successful in 2m18s
Details
5aa3ac597f 
The problem is that with VHS requests,
the list-buckets operation does not work
because the request is filtered on list-objects-v1.

Signed-off-by: Roman Loginov <r.loginov@yadro.com>
r.loginov requested review from storage-services-developers 2024-12-16 08:00:17 +00:00
r.loginov requested review from storage-services-committers 2024-12-16 08:00:17 +00:00
r.loginov force-pushed bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error from 5aa3ac597f to 84726f7b7f 2024-12-16 08:04:01 +00:00 Compare
r.loginov added 1 commit 2024-12-16 08:24:16 +00:00
Release v0.31.3
All checks were successful
/ DCO (pull_request) Successful in 3m31s
Details
/ Vulncheck (pull_request) Successful in 4m24s
Details
/ Builds (pull_request) Successful in 2m11s
Details
/ Lint (pull_request) Successful in 2m50s
Details
/ Tests (pull_request) Successful in 2m16s
Details
fa0894a7bf 
Signed-off-by: Roman Loginov <r.loginov@yadro.com>
pogpp approved these changes 2024-12-16 10:26:27 +00:00
Dismissed
dkirillov commented 2024-12-16 11:51:26 +00:00
Member
Copy link

See the same comments from #582

See the same comments from #582
r.loginov force-pushed bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error from fa0894a7bf to 3ae34fb4e6 2024-12-16 12:13:20 +00:00 Compare
r.loginov dismissed pogpp's review 2024-12-16 12:13:20 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.loginov changed title from bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 to WIP: bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 2024-12-16 12:16:22 +00:00
alexvanin added this to the v0.31.3 milestone 2024-12-16 13:36:44 +00:00
r.loginov force-pushed bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error from 3ae34fb4e6 to a2b990b870 2024-12-16 14:07:25 +00:00 Compare
r.loginov force-pushed bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error from a2b990b870 to 0f83f3ae43 2024-12-16 14:23:18 +00:00 Compare
r.loginov force-pushed bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error from 0f83f3ae43 to d52718bd1a 2024-12-16 14:28:53 +00:00 Compare
r.loginov force-pushed bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error from d52718bd1a to 94dacb3e78 2024-12-16 14:37:38 +00:00 Compare
r.loginov changed title from WIP: bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 to bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 2024-12-16 14:49:08 +00:00
r.loginov requested review from storage-services-developers 2024-12-16 14:49:08 +00:00
r.loginov requested review from storage-services-committers 2024-12-16 14:49:08 +00:00
alexvanin approved these changes 2024-12-17 06:42:12 +00:00
Dismissed
alexvanin left a comment
Owner
Copy link

Change date, please

Change date, please
r.loginov force-pushed bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error from 94dacb3e78 to 9e64ce3298 2024-12-17 06:51:18 +00:00 Compare
r.loginov dismissed alexvanin's review 2024-12-17 06:51:18 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.loginov changed title from bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 to WIP: bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 2024-12-17 07:44:43 +00:00
r.loginov force-pushed bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error from 9e64ce3298 to e721ac82f7 2024-12-17 10:16:19 +00:00 Compare
r.loginov changed title from WIP: bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 to bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error_support_v31.0 2024-12-17 10:28:39 +00:00
r.loginov requested review from storage-services-developers 2024-12-17 10:28:39 +00:00
r.loginov requested review from storage-services-committers 2024-12-17 10:28:39 +00:00
alexvanin approved these changes 2024-12-17 12:37:42 +00:00
alexvanin merged commit e721ac82f7 into support/v0.31 2024-12-17 12:38:06 +00:00
alexvanin deleted branch bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error 2024-12-17 12:38:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.31.3
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
r.loginov
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#584
No description provided.
Delete branch "r.loginov/frostfs-s3-gw:bugfix/583-fix_list_buckets_vhs_and_fix_bucket_name_conflicts_error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?