TrueCloudLab/frostfs-s3-gw
17
3
Fork 20
Code Issues 26 Pull requests 10 Projects Releases 36 Packages 1 Activity Actions

[#594] Fix unmarshal cors: expected element in name space error #600

Merged
alexvanin merged 1 commit from pogpp/frostfs-s3-gw:bugfix/594_cors_xmlns_decoder into master 2025-01-16 12:55:54 +00:00
Conversation 0 Commits 1 Files changed 5 +34 -9
pogpp commented 2025-01-15 09:08:32 +00:00
Member
Copy link

Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
mbiryukova was assigned by pogpp 2025-01-15 09:08:32 +00:00
nzinkevich was assigned by pogpp 2025-01-15 09:08:32 +00:00
alexvanin was assigned by pogpp 2025-01-15 09:08:32 +00:00
dkirillov was assigned by pogpp 2025-01-15 09:08:32 +00:00
r.loginov was assigned by pogpp 2025-01-15 09:08:32 +00:00
pogpp added 1 commit 2025-01-15 09:08:33 +00:00
[#594] Fix unmarshal cors: expected element in name space error
All checks were successful
/ DCO (pull_request) Successful in 37s
Details
/ Vulncheck (pull_request) Successful in 1m7s
Details
/ Builds (pull_request) Successful in 1m42s
Details
/ OCI image (pull_request) Successful in 2m5s
Details
/ Lint (pull_request) Successful in 2m6s
Details
/ Tests (pull_request) Successful in 1m8s
Details
33f6b1f149 
Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
requested reviews from storage-services-committers, storage-services-developers 2025-01-15 09:08:33 +00:00
alexvanin removed their assignment 2025-01-16 07:05:04 +00:00
dkirillov was unassigned by alexvanin 2025-01-16 07:05:05 +00:00
pogpp was assigned by alexvanin 2025-01-16 07:05:05 +00:00
mbiryukova was unassigned by alexvanin 2025-01-16 07:05:05 +00:00
r.loginov was unassigned by alexvanin 2025-01-16 07:05:05 +00:00
nzinkevich was unassigned by alexvanin 2025-01-16 07:05:06 +00:00
alexvanin reviewed 2025-01-16 09:21:21 +00:00
api/handler/cors_test.go Outdated
@ -20,3 +20,3 @@
</CORSConfiguration>
`
hc := prepareHandlerContext(t)
body2 := `
alexvanin commented 2025-01-16 09:21:21 +00:00
Owner
Copy link

Can we name it explicitly bodyNoXmlns

Can we name it explicitly `bodyNoXmlns`
alexvanin marked this conversation as resolved
dkirillov approved these changes 2025-01-16 12:14:08 +00:00
Dismissed
alexvanin approved these changes 2025-01-16 12:50:58 +00:00
Dismissed
pogpp force-pushed bugfix/594_cors_xmlns_decoder from 33f6b1f149 to 6dbe6b9c3b 2025-01-16 12:53:13 +00:00 Compare
pogpp dismissed dkirillov's review 2025-01-16 12:53:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pogpp dismissed alexvanin's review 2025-01-16 12:53:13 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

alexvanin approved these changes 2025-01-16 12:55:44 +00:00
alexvanin merged commit bc975989de into master 2025-01-16 12:55:54 +00:00
alexvanin deleted branch bugfix/594_cors_xmlns_decoder 2025-01-16 12:55:55 +00:00
alexvanin added this to the v0.32.1 milestone 2025-01-16 14:02:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.32.1
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
pogpp
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#600
No description provided.
Delete branch "pogpp/frostfs-s3-gw:bugfix/594_cors_xmlns_decoder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?