Send white spaces in Complete Multipart Upload #61

alexvanin · 2023-03-20T09:23:43Z

alexvanin commented

2023-03-20 09:23:43 +00:00

No description provided.

alexvanin self-assigned this 2023-03-20 09:23:43 +00:00

alexvanin added 3 commits 2023-03-20 09:23:44 +00:00

[#60 ] Implement periodic white space XML writer cf18158da4

Periodic white space XML writer sends XML header
and white spaces to the io.Writer.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>

[#60 ] Implement flusher on all http.ResponseWriters 43685e03d9

Signed-off-by: Alex Vanin <a.vanin@yadro.com>

[#60 ] Add *NoHeader functions 2282c32822

Such functions should be used together with periodic white space
XML writer.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>

dkirillov reviewed 2023-03-20 10:12:01 +00:00

api/handler/multipart_upload.go Outdated

					
				@ -426,3 +434,3 @@

						key, err := h.bearerTokenIssuerKey(r.Context())

						if err != nil {

							h.logAndSendError(w, "couldn't get gate key", reqInfo, err)

							stopPeriodicResponseWriter()

dkirillov commented

2023-03-20 10:12:01 +00:00

We invoke the same on the line below, so it seems we can get panic close already closed channel

We invoke the same on the line below, so it seems we can get panic `close already closed channel`

alexvanin commented

2023-03-20 10:34:33 +00:00

Thanks. Fixed. I thought about having once.Do in the stopper function but decided not to use it and be careful with invocations instead.

Thanks. Fixed. I thought about having `once.Do` in the stopper function but decided not to use it and be careful with invocations instead.

dkirillov marked this conversation as resolved

alexvanin force-pushed feature/60-complete-multipart-keepalive from 93be7deca0 to 648ad9913b

2023-03-20 10:21:43 +00:00

Compare

alexvanin force-pushed feature/60-complete-multipart-keepalive from 648ad9913b to 8151753eeb

2023-03-20 10:34:30 +00:00

Compare

alexvanin changed title from ~~WIP: Send white spaces in Complete Multipart Upload~~ to Send white spaces in Complete Multipart Upload

2023-03-20 10:34:51 +00:00

alexvanin requested review from dkirillov 2023-03-20 10:36:02 +00:00

alexvanin requested review from pogpp 2023-03-20 10:36:02 +00:00

alexvanin requested review from ironbee 2023-03-20 10:36:02 +00:00

dkirillov commented

2023-03-20 12:40:57 +00:00

Do we need update changelog?

👍 1

ironbee approved these changes 2023-03-20 16:25:00 +00:00

alexvanin commented

2023-03-21 07:43:59 +00:00

Add notice about missing version id in versioning bucket in complete multipart upload transfer.

alexvanin force-pushed feature/60-complete-multipart-keepalive from 6be78e38cc to 4b5f5219dc

2023-03-22 08:03:13 +00:00

Compare

alexvanin force-pushed feature/60-complete-multipart-keepalive from 122404302b to 655889a1a2

2023-03-22 08:22:18 +00:00

Compare

dkirillov approved these changes 2023-03-22 08:25:40 +00:00

alexvanin merged commit 655889a1a2 into master

2023-03-22 08:35:59 +00:00

alexvanin deleted branch feature/60-complete-multipart-keepalive

2023-03-22 08:36:00 +00:00

alexvanin referenced this pull request

2023-03-22 08:42:46 +00:00

Send white space characters to prevent timeout on Complete Multipart Upload #60

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#61