[#59] tree: Make interface for tree service client #62

dkirillov · 2023-03-21T06:30:57Z

dkirillov commented

2023-03-21 06:30:57 +00:00

close #59

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

close #59 Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

dkirillov self-assigned this 2023-03-21 06:30:57 +00:00

dkirillov requested review from storage-services-committers 2023-03-21 06:31:08 +00:00

dkirillov requested review from storage-services-developers 2023-03-21 06:31:08 +00:00

alexvanin approved these changes 2023-03-21 12:22:14 +00:00

alexvanin left a comment

Looks good. But do imports work outside of S3 project with internal package?

Looks good. But do imports work outside of S3 project with `internal` package?

dkirillov commented

2023-03-21 13:54:29 +00:00

Looks good. But do imports work outside of S3 project with internal package?

Oh, completely forgot about this. I'll fix it.

> Looks good. But do imports work outside of S3 project with `internal` package? Oh, completely forgot about this. I'll fix it.

dkirillov force-pushed feature/make_interface_for_tree_service_source from 092bb78d8a to c004453d3a

2023-03-22 09:41:16 +00:00

Compare

ale64bit reviewed 2023-03-28 10:44:45 +00:00

pkg/service/tree/tree_client_grpc.go Outdated

					
				@ -0,0 +72,4 @@

				}

				func NewTreeServiceClientGRPC(ctx context.Context, addr string, key *keys.PrivateKey) (*TreeServiceClientGRPC, error) {

					conn, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials()))

ale64bit commented

2023-03-28 10:44:45 +00:00

can we move the grpc options as arguments?

👍 1

ale64bit approved these changes 2023-03-28 10:57:12 +00:00

pkg/service/tree/tree_client_in_memory.go Outdated

					
				@ -0,0 +14,4 @@

					value []byte

				}

				func (m nodeMeta) GetKey() string {

ale64bit commented

2023-03-28 10:52:05 +00:00

I would simply remove all Get* prefixes, but up to you.

I would simply remove all `Get*` prefixes, but up to you.

pkg/service/tree/tree_client_in_memory.go Outdated

					
				@ -0,0 +309,4 @@

					parentNode := tr.createPathIfNotExist(tr.treeData, path)

					if parentNode == nil {

						return 0, errors.New("something went wrong")

ale64bit commented

2023-03-28 10:55:25 +00:00

even though it's an in-memory implementation, can we use some meaningful error messages?
e.g.

return 0, fmt.Errorf("creating path %q", path)

or similar.

Same below for the not found ones.

even though it's an in-memory implementation, can we use some meaningful error messages? e.g. ``` return 0, fmt.Errorf("creating path %q", path) ``` or similar. Same below for the `not found` ones.