TrueCloudLab/frostfs-s3-gw
17
3
Fork 19
Code Issues 28 Pull requests 6 Projects Releases 18 Packages Activity Actions

[#68] Fix pre-commit issues #68

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-gw:feature/fix-pre-commit_issues into master 2023-03-27 06:52:54 +00:00
Conversation 0 Commits 1 Files changed 21 +345 -360
dkirillov commented 2023-03-24 13:19:05 +00:00
Member
Copy link

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2023-03-24 13:19:05 +00:00
dkirillov changed title from [#XX] Fix pre-commit issues to [#68] Fix pre-commit issues 2023-03-24 13:22:00 +00:00
dkirillov force-pushed feature/fix-pre-commit_issues from bd787556b6 to bd3164c57f 2023-03-24 13:22:17 +00:00 Compare
dkirillov requested review from storage-services-committers 2023-03-24 13:22:35 +00:00
dkirillov requested review from storage-services-developers 2023-03-24 13:22:35 +00:00
alexvanin approved these changes 2023-03-24 14:39:31 +00:00
api/handler/multipart_upload.go
@ -756,4 +756,0 @@
// periodicWriterErrorSender returns handler function to send error. If header is
// alreay written by periodic XML writer, do not send HTTP and XML headers.
func (h *handler) periodicWriterErrorSender(headerWritten bool) func(http.ResponseWriter, string, *api.ReqInfo, error, ...zap.Field) {
alexvanin commented 2023-03-24 13:32:10 +00:00
Owner
Copy link

Oups.

Oups.
😆 1
docs/s3_test_results.md
@ -143,3 +80,1 @@
| 62 | s3tests_boto3.functional.test_s3.test_atomic_conditional_write_1mb | ok | ok | ERROR |
| 63 | s3tests_boto3.functional.test_s3.test_atomic_dual_conditional_write_1mb | FAIL | FAIL | FAIL |
| 64 | s3tests_boto3.functional.test_s3.test_atomic_write_bucket_gone | ok | ok | ok |
| | Test | s3-gw | minio | aws s3 |
alexvanin commented 2023-03-24 14:39:05 +00:00
Owner
Copy link

I wonder if updating script is going to be okay with this change.
Anyway we need to update it with new s3-tests based on pytest and tox.

I wonder if updating script is going to be okay with this change. Anyway we need to update it with new s3-tests based on pytest and tox.
dkirillov commented 2023-03-24 14:43:11 +00:00
Author
Member
Copy link

I wonder if updating script is going to be okay with this change.

I have checked it and it seems everything ok

> I wonder if updating script is going to be okay with this change. I have checked it and it seems everything ok
alexvanin merged commit bd3164c57f into master 2023-03-27 06:52:54 +00:00
alexvanin deleted branch feature/fix-pre-commit_issues 2023-03-27 06:52:54 +00:00
alexvanin referenced this pull request from a commit 2023-03-27 06:52:55 +00:00
[#68] Fix pre-commit issues
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-gw#68
No description provided.
Delete branch "dkirillov/frostfs-s3-gw:feature/fix-pre-commit_issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?