TrueCloudLab/frostfs-s3-lifecycler
12
0
Fork 4
Code Issues 1 Pull requests 1 Projects Releases 1 Packages Wiki Activity Actions

feature/4-add_executor #13

Merged
dkirillov merged 1 commit from dkirillov/frostfs-s3-lifecycler:feature/4-add_executor into master 2024-09-04 19:51:24 +00:00
Conversation 0 Commits 1 Files changed 2 +46 -1
dkirillov commented 2024-07-24 14:53:49 +00:00
Member
Copy link

close #4

close #4
dkirillov self-assigned this 2024-07-24 14:53:49 +00:00
dkirillov added 3 commits 2024-07-24 14:53:54 +00:00 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
[#4] Support object expiration
Some checks failed
/ DCO (pull_request) Successful in 1m0s
Details
/ Vulncheck (pull_request) Successful in 1m16s
Details
/ Builds (1.21) (pull_request) Successful in 1m20s
Details
/ Builds (1.22) (pull_request) Successful in 3m8s
Details
/ Lint (pull_request) Successful in 2m37s
Details
/ Tests (1.21) (pull_request) Failing after 1m22s
Details
/ Tests (1.22) (pull_request) Successful in 3m6s
Details
75cdd50ba3 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov added 2 commits 2024-07-25 12:26:53 +00:00 
Don't init listing on every rule in configuration. Use just one

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
[#4] Add more tests
Some checks failed
/ DCO (pull_request) Successful in 46s
Details
/ Vulncheck (pull_request) Successful in 1m16s
Details
/ Builds (1.21) (pull_request) Successful in 1m36s
Details
/ Builds (1.22) (pull_request) Successful in 1m34s
Details
/ Lint (pull_request) Successful in 1m50s
Details
/ Tests (1.21) (pull_request) Failing after 1m30s
Details
/ Tests (1.22) (pull_request) Failing after 1m23s
Details
7539f43a9a 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed feature/4-add_executor from 7539f43a9a to 4bdde21ccf 2024-07-25 12:52:49 +00:00 Compare
dkirillov requested review from storage-services-developers 2024-07-25 12:52:58 +00:00
dkirillov requested review from storage-services-committers 2024-07-25 12:53:01 +00:00
dkirillov changed title from WIP: feature/4-add_executor to feature/4-add_executor 2024-07-25 12:53:13 +00:00
alexvanin reviewed 2024-07-26 10:38:50 +00:00
alexvanin left a comment
Owner
Copy link

Looks great overall! I would like to add some more tests for match-functions but we can do it later.

Looks great overall! I would like to add some more tests for match-functions but we can do it later.
internal/frostfs/tree.go Outdated
@ -120,0 +116,4 @@
// // it provides compatibility with previous tree service api where
// // single uint64(0) value is dropped from signature
// poolPrm.RootID = nil
//}
alexvanin commented 2024-07-26 09:37:32 +00:00
Owner
Copy link

Do you want to keep it in the code or just forgot to remove?

Do you want to keep it in the code or just forgot to remove?
alexvanin marked this conversation as resolved
internal/lifecycle/executor.go Outdated
@ -0,0 +106,4 @@
})
if err != nil {
wg.Done()
alexvanin commented 2024-07-26 09:46:55 +00:00
Owner
Copy link

I don't mind having two wg.Done() but it seems like we can do it once in the end of case statement.

I don't mind having two `wg.Done()` but it seems like we can do it once in the end of case statement.
dkirillov commented 2024-07-26 11:47:20 +00:00
Author
Member
Copy link

Actually we cannot. We have to invoke wg.Done() after task is done. End of Submit doesn't guaranties that task was ended.

Actually we cannot. We have to invoke `wg.Done()` after task is done. End of `Submit` doesn't guaranties that task was ended.
alexvanin commented 2024-07-26 12:34:25 +00:00
Owner
Copy link

Yep, missed that it is non-blocking operation.

Yep, missed that it is non-blocking operation.
alexvanin marked this conversation as resolved
internal/lifecycle/executor.go Outdated
@ -0,0 +140,4 @@
if ni.CurrentEpoch() != job.Epoch {
ni.SetCurrentEpoch(job.Epoch)
}
alexvanin commented 2024-07-26 09:48:53 +00:00
Owner
Copy link

Is it worth a warning?

Is it worth a warning?
alexvanin marked this conversation as resolved
internal/lifecycle/executor.go Outdated
@ -0,0 +203,4 @@
if len(matchers) == 0 {
return nil, errNotApplicableRule
}
alexvanin commented 2024-07-26 09:54:30 +00:00
Owner
Copy link

Is it an error, actually?
This function returns error, then it is returned by abortMultiparts() and then logged as a WARN in worker().
Maybe we should ignore this error in the worker() but I don't see any usage of this error in this case.

Is it an error, actually? This function returns error, then it is returned by `abortMultiparts()` and then logged as a _WARN_ in `worker()`. Maybe we should ignore this error in the `worker()` but I don't see any usage of this error in this case.
dkirillov commented 2024-07-26 11:50:32 +00:00
Author
Member
Copy link

Sometimes it can be useful to see that we don't do anything despite rules are not empty. But I can add ignoring this error in worker

Sometimes it can be useful to see that we don't do anything despite rules are not empty. But I can add ignoring this error in `worker`
alexvanin marked this conversation as resolved
dkirillov force-pushed feature/4-add_executor from 4bdde21ccf to 15c9d55b03 2024-07-26 11:52:43 +00:00 Compare
dkirillov added 1 commit 2024-07-26 11:57:44 +00:00
[#4] Don't check tags for multiparts
All checks were successful
/ DCO (pull_request) Successful in 1m7s
Details
/ Vulncheck (pull_request) Successful in 1m16s
Details
/ Builds (1.21) (pull_request) Successful in 1m24s
Details
/ Builds (1.22) (pull_request) Successful in 1m20s
Details
/ Lint (pull_request) Successful in 2m11s
Details
/ Tests (1.21) (pull_request) Successful in 1m21s
Details
/ Tests (1.22) (pull_request) Successful in 1m18s
Details
127816c66a 
Spec https://docs.aws.amazon.com/AmazonS3/latest/userguide/lifecycle-configuration-examples.html#lc-expire-mpu
says: "When you use the AbortIncompleteMultipartUpload S3
 Lifecycle action, the rule cannot specify a tag-based filter."

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
mbiryukova reviewed 2024-07-26 12:37:27 +00:00
internal/lifecycle/executor.go
@ -0,0 +198,4 @@
if err != nil && !errors.Is(err, errNotApplicableRule) {
return nil, err
}
mbiryukova commented 2024-07-26 11:55:53 +00:00
Member
Copy link

Seems that in case of errNotApplicableRule we can't use matchFn because it's nil

Seems that in case of `errNotApplicableRule` we can't use `matchFn` because it's nil
👍 1
alexvanin approved these changes 2024-07-26 12:54:44 +00:00
dkirillov force-pushed feature/4-add_executor from 127816c66a to b3374bb565 2024-07-26 13:47:18 +00:00 Compare
alexvanin approved these changes 2024-07-26 14:07:35 +00:00
dkirillov merged commit b3374bb565 into master 2024-07-26 14:17:24 +00:00
dkirillov deleted branch feature/4-add_executor 2024-07-26 14:17:27 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-lifecycler#13
No description provided.
Delete branch "dkirillov/frostfs-s3-lifecycler:feature/4-add_executor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?