TrueCloudLab/frostfs-s3-lifecycler

WIP: [#25] Use expiration epoch instead of date #25

Draft

mbiryukova wants to merge 1 commit from mbiryukova/frostfs-s3-lifecycler:feature/use_expiration_epoch into master

mbiryukova commented

2024-10-15 13:15:56 +00:00

Member

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova self-assigned this 2024-10-15 13:15:56 +00:00

mbiryukova added 1 commit 2024-10-15 13:15:56 +00:00

[#xx] Use expiration epoch instead of date

/ DCO (pull_request) Successful in 1m43s

Details

/ Builds (pull_request) Successful in 1m5s

Details

/ Vulncheck (pull_request) Successful in 1m47s

Details

/ Lint (pull_request) Successful in 2m22s

Details

/ Tests (pull_request) Successful in 1m2s

Details

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova force-pushed feature/use_expiration_epoch from 9ba1da6f63 to 2f951e5de8

2024-10-15 13:16:39 +00:00

Compare

mbiryukova changed title from ~~WIP: [#xx] Use expiration epoch instead of date~~ to WIP: [#25] Use expiration epoch instead of date

2024-10-15 13:17:55 +00:00

dkirillov reviewed 2024-10-16 08:08:48 +00:00

internal/frostfs/tree.go

					
				@ -102,3 +102,3 @@

				}

				func (w *TreePoolWrapper) GetSubTree(ctx context.Context, bktInfo *data.BucketInfo, treeID string, rootID []uint64, depth uint32) ([]tree.NodeResponse, error) {

				func (w *TreePoolWrapper) GetSubTree(ctx context.Context, bktInfo *data.BucketInfo, treeID string, rootID []uint64, depth uint32, sort bool) ([]tree.NodeResponse, error) {

dkirillov commented

2024-10-16 08:08:48 +00:00

Member

Maybe we can use this pool wrapper from s3-gw? It requires move PooWrapper type into pkg in s3-gw repo, but still.

Maybe we can use this pool wrapper from s3-gw? It requires move `PooWrapper` type into pkg in s3-gw repo, but still. cc @alexvanin

/ DCO (pull_request) Successful in 1m11s

Details

/ Vulncheck (pull_request) Successful in 1m28s

Details

/ Builds (pull_request) Successful in 1m18s

Details

/ Lint (pull_request) Successful in 2m39s

Details

/ Tests (pull_request) Successful in 1m34s

Details

This pull request is marked as a work in progress.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u feature/use_expiration_epoch:mbiryukova-feature/use_expiration_epoch

git checkout mbiryukova-feature/use_expiration_epoch

Merge

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff mbiryukova-feature/use_expiration_epoch

git checkout master

git merge --ff-only mbiryukova-feature/use_expiration_epoch

git checkout mbiryukova-feature/use_expiration_epoch

git rebase master

git checkout master

git merge --no-ff mbiryukova-feature/use_expiration_epoch

git checkout master

git merge --squash mbiryukova-feature/use_expiration_epoch

git checkout master

git merge --ff-only mbiryukova-feature/use_expiration_epoch

git checkout master

git merge mbiryukova-feature/use_expiration_epoch

git push origin master

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-lifecycler#25

No description provided.