TrueCloudLab/frostfs-s3-lifecycler
12
0
Fork 4
Code Issues 1 Pull requests 1 Projects Releases 1 Packages Wiki Activity Actions

[#1] Add basic repository structure #5

Merged
alexvanin merged 1 commit from dkirillov/frostfs-s3-lifecycler:feature/1-basic_structure into master 2024-07-03 07:15:43 +00:00
Conversation 0 Commits 1 Files changed 30 +1370
dkirillov commented 2024-07-01 07:01:39 +00:00
Member
Copy link

close #1

close #1
dkirillov self-assigned this 2024-07-01 07:01:39 +00:00
dkirillov requested review from storage-services-committers 2024-07-01 07:01:55 +00:00
dkirillov requested review from storage-services-developers 2024-07-01 07:01:57 +00:00
fyrchik reviewed 2024-07-01 07:16:53 +00:00
CREDITS.md Outdated
@ -0,0 +2,4 @@
In alphabetical order:
- Denis Kirillov
fyrchik commented 2024-07-01 07:16:53 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
fyrchik reviewed 2024-07-01 07:16:56 +00:00
CREDITS.md Outdated
@ -0,0 +2,4 @@
In alphabetical order:
- Denis Kirillov
fyrchik commented 2024-07-01 07:16:56 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
dkirillov marked this conversation as resolved
fyrchik reviewed 2024-07-01 07:16:59 +00:00
CREDITS.md Outdated
@ -0,0 +2,4 @@
In alphabetical order:
- Denis Kirillov
fyrchik commented 2024-07-01 07:16:59 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
dkirillov marked this conversation as resolved
fyrchik reviewed 2024-07-01 07:17:01 +00:00
CREDITS.md Outdated
@ -0,0 +2,4 @@
In alphabetical order:
- Denis Kirillov
fyrchik commented 2024-07-01 07:17:00 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
dkirillov marked this conversation as resolved
fyrchik reviewed 2024-07-01 07:17:05 +00:00
CREDITS.md Outdated
@ -0,0 +2,4 @@
In alphabetical order:
- Denis Kirillov
fyrchik commented 2024-07-01 07:17:04 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
fyrchik commented 2024-07-01 07:17:04 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
fyrchik commented 2024-07-01 07:17:04 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
fyrchik commented 2024-07-01 07:17:08 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
fyrchik commented 2024-07-01 07:17:08 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
fyrchik commented 2024-07-01 07:17:08 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
fyrchik commented 2024-07-01 07:17:08 +00:00
Owner
Copy link

Maybe put account name somewhere near? Not everyone has real name :D

Maybe put account name somewhere near? Not everyone has real name :D
dkirillov marked this conversation as resolved
dkirillov force-pushed feature/1-basic_structure from 0a069c30d1 to 0fff4a0131 2024-07-01 08:14:39 +00:00 Compare
dkirillov force-pushed feature/1-basic_structure from 0fff4a0131 to 196bafad4b 2024-07-01 08:16:41 +00:00 Compare
alexvanin approved these changes 2024-07-02 06:45:46 +00:00
.docker/Dockerfile Outdated
@ -0,0 +1,20 @@
FROM golang:1.21 as builder
alexvanin commented 2024-07-02 06:42:03 +00:00
Owner
Copy link

Let's use 1.22

Let's use 1.22
alexvanin marked this conversation as resolved
Makefile Outdated
@ -0,0 +2,4 @@
REPO ?= $(shell go list -m)
VERSION ?= $(shell git describe --tags --match "v*" --dirty --always --abbrev=8 2>/dev/null || cat VERSION 2>/dev/null || echo "develop")
GO_VERSION ?= 1.21
alexvanin commented 2024-07-02 06:42:53 +00:00
Owner
Copy link

Maybe 1.22?

Maybe 1.22?
dkirillov commented 2024-07-02 08:01:50 +00:00
Author
Member
Copy link

I would use the version that is fixed in go.mod, the same for dockerfile

I would use the version that is fixed in go.mod, the same for dockerfile
alexvanin marked this conversation as resolved
config/config.yaml Outdated
@ -0,0 +1,11 @@
logger:
alexvanin commented 2024-07-02 06:45:13 +00:00
Owner
Copy link

Do we skip .env file this time?

Do we skip .env file this time?
dkirillov commented 2024-07-02 07:59:57 +00:00
Author
Member
Copy link

Oh, I've forgot about this. I'll fix it

Oh, I've forgot about this. I'll fix it
alexvanin marked this conversation as resolved
dkirillov force-pushed feature/1-basic_structure from 196bafad4b to 4e71fbeba6 2024-07-02 09:15:09 +00:00 Compare
alexvanin merged commit 4e71fbeba6 into master 2024-07-03 07:15:42 +00:00
alexvanin deleted branch feature/1-basic_structure 2024-07-03 07:16:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-services-developers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-s3-lifecycler#5
No description provided.
Delete branch "dkirillov/frostfs-s3-lifecycler:feature/1-basic_structure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?