TrueCloudLab/frostfs-sdk-csharp
19
0
Fork 4
Code Issues 5 Pull requests Projects Releases Packages Activity Actions

[#10] Netmap snapshot, options, metrics #11

Merged
PavelGrossSpb merged 1 commit from PavelGrossSpb/frostfs-sdk-csharp:Netmap_Options_Metrics into master 2024-06-26 09:30:39 +00:00
Conversation 0 Commits 1 Files changed 84 +2238 -933
PavelGrossSpb commented 2024-06-24 11:13:20 +00:00
Member
Copy link

Signed-off-by: Pavel Gross p.gross@yadro.com

Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb requested review from dstepanov-yadro 2024-06-24 11:14:39 +00:00
PavelGrossSpb requested review from orikik 2024-06-24 11:14:39 +00:00
dstepanov-yadro requested changes 2024-06-24 13:00:42 +00:00
src/FrostFS.SDK.ClientV2/Client.cs Outdated
@ -49,0 +47,4 @@
return new Client(settings, containerService, netmapService, sessionService, objectService);
}
private Client(
dstepanov-yadro commented 2024-06-24 12:33:24 +00:00
Member
Copy link

If Client is disposable, then how it can be disposed having private constructor?

If `Client` is disposable, then how it can be disposed having private constructor?
PavelGrossSpb commented 2024-06-25 08:59:14 +00:00
Author
Member
Copy link

Thx, I forgot to inherit the interface from IDisposable

public interface IFrostFSClient : IDisposable

this way is recommended:
using var fsClient = Client.GetInstance(GetOptions(this.key, this.url), channelOptions);

or Dispose directly
var fsClient = Client.GetInstance(GetOptions(this.key, this.url), channelOptions);
...
fsClient.Dispose();

Thx, I forgot to inherit the interface from IDisposable ``public interface IFrostFSClient : IDisposable`` this way is recommended: ``using var fsClient = Client.GetInstance(GetOptions(this.key, this.url), channelOptions);`` or Dispose directly `` var fsClient = Client.GetInstance(GetOptions(this.key, this.url), channelOptions);`` ``...`` ``fsClient.Dispose();``
dstepanov-yadro marked this conversation as resolved
src/FrostFS.SDK.ClientV2/Tools/ClientEnvironment.cs Outdated
@ -0,0 +25,4 @@
internal bool IsEventRequested => GrpcInvokedEvent != null;
internal async Task<T> InvokeAsyncWithMetrics<T>(Func<Task<T>> func, string methodName)
dstepanov-yadro commented 2024-06-24 12:58:47 +00:00
Member
Copy link

Looks like the same result could be the same result can be achieved with the interceptor list for GrpcChannel. If it is really required I'm ok with this. But other option is to allow to pass GrpcChannel to Client, so SDK user could add any interceptors to grpc pipeline.

Looks like the same result could be the same result can be achieved with the interceptor list for GrpcChannel. If it is really required I'm ok with this. But other option is to allow to pass GrpcChannel to `Client`, so SDK user could add any interceptors to grpc pipeline.
PavelGrossSpb commented 2024-06-25 09:01:16 +00:00
Author
Member
Copy link

Good idea. GRPC channal is available now to add any interceptors

Good idea. GRPC channal is available now to add any interceptors
dstepanov-yadro marked this conversation as resolved
src/FrostFS.SDK.ModelsV2/SplitId.cs Outdated
@ -0,0 +25,4 @@
this.id = new Guid(str);
}
public static SplitId CrateFromBinary(byte[] binaryData)
dstepanov-yadro commented 2024-06-24 12:52:18 +00:00
Member
Copy link

CrateFromBinary -> CreateFromBinary

CrateFromBinary -> Cr**e**ateFromBinary
PavelGrossSpb commented 2024-06-25 09:01:36 +00:00
Author
Member
Copy link

Fixed.

Fixed.
dstepanov-yadro commented 2024-06-25 11:48:49 +00:00
Member
Copy link

Don't see any changes

Don't see any changes
PavelGrossSpb commented 2024-06-25 12:46:57 +00:00
Author
Member
Copy link

Pushed.

Pushed.
dstepanov-yadro marked this conversation as resolved
PavelGrossSpb added 4 commits 2024-06-25 09:13:02 +00:00 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb requested review from dstepanov-yadro 2024-06-25 09:17:17 +00:00
dstepanov-yadro reviewed 2024-06-25 11:45:19 +00:00
src/FrostFS.SDK.ClientV2/FrostFS.SDK.ClientV2.csproj Outdated
@ -11,1 +16,3 @@
<PackageReference Include="Moq.AutoMock" Version="3.5.0" />
<PackageReference Include="Microsoft.Extensions.Options" Version="8.0.2" />
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" />
<PackageReference Include="System.Net.Http.WinHttpHandler" Version="8.0.0" />
dstepanov-yadro commented 2024-06-25 11:45:18 +00:00
Member
Copy link

Why cross-platform SDK have Windows dependency?

Why cross-platform SDK have Windows dependency?
PavelGrossSpb commented 2024-06-25 12:48:04 +00:00
Author
Member
Copy link

Right. These are some artefacts from my research. Wrong references have been removed.

Right. These are some artefacts from my research. Wrong references have been removed.
dstepanov-yadro marked this conversation as resolved
PavelGrossSpb force-pushed Netmap_Options_Metrics from f68dd1c9a4 to 7cd7d6ef96 2024-06-25 12:45:36 +00:00 Compare
orikik approved these changes 2024-06-26 08:00:28 +00:00
dstepanov-yadro approved these changes 2024-06-26 08:27:18 +00:00
PavelGrossSpb force-pushed Netmap_Options_Metrics from 841107301f to e9603dff28 2024-06-26 09:08:42 +00:00 Compare
PavelGrossSpb force-pushed Netmap_Options_Metrics from 4164864e64 to b69d22966f 2024-06-26 09:28:50 +00:00 Compare
PavelGrossSpb added 1 commit 2024-06-26 09:30:02 +00:00
[#11] Add Network Snapshot
All checks were successful
DCO / DCO (pull_request) Successful in 41s
Details
c988ff3c76 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb merged commit c988ff3c76 into master 2024-06-26 09:30:39 +00:00
PavelGrossSpb deleted branch Netmap_Options_Metrics 2024-06-26 09:30:40 +00:00
PavelGrossSpb referenced this pull request from a commit 2024-06-26 09:30:41 +00:00
[#11] Add Network Snapshot
Sign in to join this conversation.
Reviewers
No reviewers
orikik
dstepanov-yadro
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-csharp#11
No description provided.
Delete branch "PavelGrossSpb/frostfs-sdk-csharp:Netmap_Options_Metrics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?