TrueCloudLab/frostfs-sdk-csharp
16
0
Fork 3
Code Issues 5 Pull requests Projects Releases Packages Activity Actions

[#13] Change GetObject result to stream #12

Merged
PavelGrossSpb merged 1 commit from PavelGrossSpb/frostfs-sdk-csharp:ObjectDownloader into master 2024-09-04 19:51:24 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -23
PavelGrossSpb commented 2024-06-26 12:19:21 +00:00
Member
Copy link

The result of GetObject method has been changed to stream instead of byte buffer. The logic from the prototype is not applicable for large objects.

The result of GetObject method has been changed to stream instead of byte buffer. The logic from the prototype is not applicable for large objects.
PavelGrossSpb added 1 commit 2024-06-26 12:19:26 +00:00
[#13] Change GetObject result to stream
All checks were successful
DCO / DCO (pull_request) Successful in 42s
Details
f5d1899dd2 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb requested review from orikik 2024-06-26 12:19:43 +00:00
PavelGrossSpb requested review from dstepanov-yadro 2024-06-26 12:19:58 +00:00
PavelGrossSpb added 1 commit 2024-06-26 12:24:40 +00:00
[#13] Add cancellation token to GetChank method
All checks were successful
DCO / DCO (pull_request) Successful in 40s
Details
17492ee871 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
dstepanov-yadro requested changes 2024-06-27 09:15:37 +00:00
src/FrostFS.SDK.ClientV2/Services/ObjectServiceProvider.cs Outdated
@ -334,1 +328,3 @@
return obj;
// return obj.ToModel();
// var payload = new byte[obj.Header.PayloadLength];
dstepanov-yadro commented 2024-06-27 09:15:20 +00:00
Member
Copy link

Please drop this comments.

Please drop this comments.
PavelGrossSpb commented 2024-06-27 09:40:42 +00:00
Author
Member
Copy link

Done

Done
PavelGrossSpb added 1 commit 2024-06-27 09:38:38 +00:00
[#13] Drop comments
All checks were successful
DCO / DCO (pull_request) Successful in 44s
Details
605463ec24 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb requested review from dstepanov-yadro 2024-06-28 09:14:35 +00:00
orikik approved these changes 2024-06-28 12:31:12 +00:00
orikik approved these changes 2024-06-28 12:31:22 +00:00
orikik approved these changes 2024-06-28 12:31:46 +00:00
PavelGrossSpb merged commit 605463ec24 into master 2024-06-28 12:33:15 +00:00
PavelGrossSpb deleted branch ObjectDownloader 2024-06-28 12:33:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
orikik
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-csharp#12
No description provided.
Delete branch "PavelGrossSpb/frostfs-sdk-csharp:ObjectDownloader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?