TrueCloudLab/frostfs-sdk-csharp
16
0
Fork 3
Code Issues 5 Pull requests Projects Releases Packages Activity Actions

[#17] Client: Add extra parameter #18

Merged
PavelGrossSpb merged 1 commit from PavelGrossSpb/frostfs-sdk-csharp:misc/extra_parameters into master 2024-09-04 19:51:24 +00:00
Conversation 0 Commits 1 Files changed 4 +6 -22
PavelGrossSpb commented 2024-07-18 12:39:05 +00:00
Member
Copy link

API methods' parameters types with optional session, polling settings, xHeaders etc. and corresponding handlers have been added

Signed-off-by: Pavel Gross p.gross@yadro.com

API methods' parameters types with optional session, polling settings, xHeaders etc. and corresponding handlers have been added Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb added 1 commit 2024-07-18 12:39:11 +00:00
[#17] Client: Add extra parameter
All checks were successful
DCO / DCO (pull_request) Successful in 47s
Details
7b9c19f37c 
API methods' parameters types with optional session, polling settings, xHeaders etc. and corresponding handlers have been added

Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb requested review from orikik 2024-07-18 12:39:29 +00:00
PavelGrossSpb requested review from dstepanov-yadro 2024-07-18 12:39:41 +00:00
orikik approved these changes 2024-07-22 07:59:40 +00:00
dstepanov-yadro reviewed 2024-07-22 08:12:39 +00:00
src/FrostFS.SDK.ModelsV2/FrostFS.SDK.ModelsV2.csproj Outdated
@ -20,1 +20,4 @@
<ItemGroup>
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>FrostFS.SDK.ClientV2</_Parameter1>
dstepanov-yadro commented 2024-07-22 08:12:03 +00:00
Member
Copy link

Looks like dirty hack. As far as I remember, this should be used only for unit tests.

Looks like dirty hack. As far as I remember, this should be used only for unit tests.
PavelGrossSpb added 1 commit 2024-07-22 11:19:05 +00:00
[#17] Models: Remove internal visibility
All checks were successful
DCO / DCO (pull_request) Successful in 42s
Details
9207683acf 
Signed-off-by: p.gross <p.gross@yando.com>
PavelGrossSpb added 1 commit 2024-07-22 11:46:46 +00:00
[#17] Models: Remove internal visibility
All checks were successful
DCO / DCO (pull_request) Successful in 7m36s
Details
ffb6fa869b 
Signed-off-by: Pavel Gross <p.gross@yando.com>
PavelGrossSpb force-pushed misc/extra_parameters from ffb6fa869b to 816e1eb2f1 2024-07-22 11:51:02 +00:00 Compare
PavelGrossSpb merged commit 816e1eb2f1 into master 2024-07-23 13:22:29 +00:00
PavelGrossSpb deleted branch misc/extra_parameters 2024-07-23 13:22:30 +00:00
PavelGrossSpb referenced this pull request from a commit 2024-07-25 10:29:57 +00:00
[#18] Client: Rename parameters
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
orikik
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-csharp#18
No description provided.
Delete branch "PavelGrossSpb/frostfs-sdk-csharp:misc/extra_parameters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?