[#20] Optimize memory usage #22

PavelGrossSpb · 2024-08-05T08:23:50Z

PavelGrossSpb commented

2024-08-05 08:23:50 +00:00

Provide custom buffer and use ArrayPool

Signed-off-by: Pavel Gross p.gross@yando.com

Provide custom buffer and use ArrayPool Signed-off-by: Pavel Gross <p.gross@yando.com>

PavelGrossSpb added 1 commit 2024-08-05 08:23:57 +00:00

[#20 ] Optimize memory usage

DCO / DCO (pull_request) Successful in 27s

Details

18126ea763

Provide custom buffer and use ArrayPool

Signed-off-by: Pavel Gross <p.gross@yando.com>

PavelGrossSpb requested review from dstepanov-yadro 2024-08-05 08:24:17 +00:00

PavelGrossSpb requested review from orikik 2024-08-05 08:24:17 +00:00

fyrchik reviewed 2024-08-05 12:40:21 +00:00

src/FrostFS.SDK.ClientV2/Tools/ClientEnvironment.cs

					
				@ -9,3 +10,4 @@

				public class ClientEnvironment(Client client, ECDsa key, OwnerId owner, GrpcChannel channel, ModelsV2.Version version) : IDisposable

				{

				    private ArrayPool<byte> _arrayPool;

fyrchik commented

2024-08-05 12:40:21 +00:00

Purely out of interest, where can I find implementation details of this pool?
I have found only abstract class 5535e31a71/src/libraries/System.Private.CoreLib/src/System/Buffers/ArrayPool.cs

Purely out of interest, where can I find implementation details of this pool? I have found only abstract class https://github.com/dotnet/runtime/blob/5535e31a712343a63f5d7d796cd874e563e5ac14/src/libraries/System.Private.CoreLib/src/System/Buffers/ArrayPool.cs

dstepanov-yadro commented

2024-08-06 14:35:22 +00:00

ab35b89f03/src/libraries/System.Private.CoreLib/src/System/Buffers/ConfigurableArrayPool.cs (L9)

ab35b89f03/src/libraries/System.Private.CoreLib/src/System/Buffers/TlsOverPerCoreLockedStacksArrayPool.cs

https://github.com/dotnet/runtime/blob/ab35b89f037b0fa7cb68668ad2dfa93b6bc38462/src/libraries/System.Private.CoreLib/src/System/Buffers/ConfigurableArrayPool.cs#L9 https://github.com/dotnet/runtime/blob/ab35b89f037b0fa7cb68668ad2dfa93b6bc38462/src/libraries/System.Private.CoreLib/src/System/Buffers/TlsOverPerCoreLockedStacksArrayPool.cs