feature/netstandard2 #3

PavelGrossSpb · 2024-05-29T16:30:34Z

PavelGrossSpb commented

2024-05-29 16:30:34 +00:00

No description provided.

alexvanin was assigned by PavelGrossSpb

2024-05-29 16:30:34 +00:00

pogpp was assigned by PavelGrossSpb

2024-05-29 16:30:35 +00:00

PavelGrossSpb added 1 commit 2024-05-29 16:30:37 +00:00

Move to netstandard 2.0

DCO / DCO (pull_request) Failing after 42s

Details

4ea24e958c

PavelGrossSpb changed title from ~~Move to netstandard 2.0~~ to feature/netstandard2

2024-05-29 16:43:34 +00:00

PavelGrossSpb closed this pull request

2024-05-29 16:56:38 +00:00

PavelGrossSpb reopened this pull request

2024-05-29 16:58:23 +00:00

PavelGrossSpb requested review from alexvanin 2024-05-30 07:48:01 +00:00

PavelGrossSpb requested review from pogpp 2024-05-30 07:48:01 +00:00

alexvanin was unassigned by PavelGrossSpb

2024-05-30 07:48:11 +00:00

pogpp was unassigned by PavelGrossSpb

2024-05-30 07:48:11 +00:00

alexvanin commented

2024-05-30 08:19:37 +00:00

@PavelGrossSpb To pass DCO check commit message should contain:

gitea issue number
sign-off message

Gitea issue number

Link an issue in [] brackets based on the issue number in this repository. If issue does not exist, like in this case, use PR number, e.g. #3 for this PR. Issue and PR numbers do not overlap.

Sign-off message
Add sign-off trailer to your commit by using -s flag. See How to sign-off commits, git-commit

In the end, your commit should look like this:

[#3] Move to netstandard 2.0

Signed-off-by: Pavel Gross <email@example.com>

@PavelGrossSpb To pass DCO check commit message should contain: * gitea issue number * sign-off message **Gitea issue number** Link an issue in `[]` brackets based on the [issue number](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-csharp/issues) in this repository. If issue does not exist, like in this case, use PR number, e.g. #3 for this PR. Issue and PR numbers do not overlap. **Sign-off message** Add sign-off trailer to your commit by using `-s` flag. See [How to sign-off commits](https://docs.pi-hole.net/guides/github/how-to-signoff/), [git-commit](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s) In the end, your commit should look like this: ``` [#3] Move to netstandard 2.0 Signed-off-by: Pavel Gross <email@example.com> ```

alexvanin referenced this pull request

2024-05-30 08:21:58 +00:00

Add CONTRIBUTING.md file #4

alexvanin approved these changes 2024-05-30 08:37:46 +00:00

alexvanin left a comment

LGTM

src/FrostFS.SDK.ProtosV2/session/Extension.XHeader.cs Outdated

					
				@ -6,3 +5,1 @@

				        public const string XHeaderNetmapEpoch = ReservedXHeaderPrefix + "NETMAP_EPOCH";

				        public const string XHeaderNetmapLookupDepth = ReservedXHeaderPrefix + "NETMAP_LOOKUP_DEPTH";

				    }

				    public const string ReservedXHeaderPrefix = "__NEOFS__";