TrueCloudLab/frostfs-sdk-csharp
19
0
Fork 4
Code Issues 5 Pull requests Projects Releases Packages Activity Actions

[#28] Client: add method to calculate ObjectId #38

Merged
PavelGrossSpb merged 3 commits from PavelGrossSpb/frostfs-sdk-csharp:misc/CalculateObjectId into master 2024-12-12 12:28:46 +00:00
Conversation 0 Commits 3 Files changed 4 +78 -19
PavelGrossSpb commented 2024-12-10 07:52:33 +00:00
Member
Copy link

Signed-off-by: Pavel Gross p.gross@yadro.com

Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb added 1 commit 2024-12-10 07:52:33 +00:00
[#28] Client: add method to calculate ObjectId
All checks were successful
lint-build / dotnet8.0 (pull_request) Successful in 55s
Details
DCO / DCO (pull_request) Successful in 1m6s
Details
8cfa9a4937 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb requested review from dstepanov-yadro 2024-12-10 07:52:59 +00:00
PavelGrossSpb requested review from orikik 2024-12-10 07:53:00 +00:00
dstepanov-yadro reviewed 2024-12-10 07:57:36 +00:00
src/FrostFS.SDK.Client/Interfaces/IFrostFSClient.cs Outdated
@ -66,2 +66,4 @@
public Task<string?> Dial(CallContext ctx);
FrostFsObjectId CalculateObjectId(FrostFsObjectHeader header);
dstepanov-yadro commented 2024-12-10 07:57:36 +00:00
Member
Copy link

I don't think that IFrostFSClient should have this method, as there is no need to do any FrostFS RPC's to calculate object ID.

I don't think that `IFrostFSClient` should have this method, as there is no need to do any FrostFS RPC's to calculate object ID.
PavelGrossSpb commented 2024-12-10 12:03:49 +00:00
Author
Member
Copy link

OK, I had the same thounghts. I've moved the method to static tools.

OK, I had the same thounghts. I've moved the method to static tools.
PavelGrossSpb commented 2024-12-12 10:16:19 +00:00
Author
Member
Copy link

@dstepanov-yadro @orikik Please take a look at the PR

@dstepanov-yadro @orikik Please take a look at the PR
PavelGrossSpb added 1 commit 2024-12-10 12:02:07 +00:00
[#28] Client: Move CalculateObjectId from IFrostFsClient to statis tools
All checks were successful
DCO / DCO (pull_request) Successful in 42s
Details
lint-build / dotnet8.0 (pull_request) Successful in 1m18s
Details
a643baa4af 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb added 1 commit 2024-12-11 09:58:23 +00:00
[#28] Client: Move CalculateObjectId from IFrostFsClient to statis tools
All checks were successful
lint-build / dotnet8.0 (pull_request) Successful in 1m13s
Details
DCO / DCO (pull_request) Successful in 2m41s
Details
7fd60805e7 
Get payload hash as an argument

Signed-off-by: Pavel Gross <p.gross@yadro.com>
orikik approved these changes 2024-12-12 12:20:21 +00:00
PavelGrossSpb merged commit 8637515869 into master 2024-12-12 12:28:46 +00:00
PavelGrossSpb deleted branch misc/CalculateObjectId 2024-12-12 12:28:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
orikik
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-csharp#38
No description provided.
Delete branch "PavelGrossSpb/frostfs-sdk-csharp:misc/CalculateObjectId"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?