TrueCloudLab/frostfs-sdk-csharp
18
0
Fork 4
Code Issues 4 Pull requests Projects Releases Packages 3 Activity Actions

[#30] Client: Add object model for Rules #42

Merged
orikik merged 1 commit from PavelGrossSpb/frostfs-sdk-csharp:apeRules into master 2025-02-13 07:05:01 +00:00
Conversation 0 Commits 1 Files changed 27 +677 -155
PavelGrossSpb commented 2025-02-12 01:22:04 +00:00
Member
Copy link

Signed-off-by: Pavel Gross p.gross@yadro.com

Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb added 1 commit 2025-02-12 01:22:05 +00:00
[#30] Client: Add object model for Rules
All checks were successful
DCO / DCO (pull_request) Successful in 29s
Details
lint-build / dotnet8.0 (pull_request) Successful in 44s
Details
cdad8ad3a8 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
requested reviews from dstepanov-yadro, orikik 2025-02-12 01:22:57 +00:00
dstepanov-yadro requested changes 2025-02-12 12:57:26 +00:00
Dismissed
src/FrostFS.SDK.Client/ApeRules/RuleSerializer.cs Outdated
@ -0,0 +91,4 @@
private static int ActionsSize(Actions? action)
{
return BoolSize // Inverted
+ (action != null ? SliceSize(action.Names, StringSize) : 0);
dstepanov-yadro commented 2025-02-12 12:54:06 +00:00
Member
Copy link

Null slice must have size 1

Null slice must have size 1
PavelGrossSpb commented 2025-02-12 13:22:54 +00:00
Author
Member
Copy link

Seems that Golang SDK is not protected from null Action or Resources and panics in these cases. So, null Action/Resourse makes the rule invalid. I've fixed the code accordingly.

Seems that Golang SDK is not protected from null Action or Resources and panics in these cases. So, null Action/Resourse makes the rule invalid. I've fixed the code accordingly.
dstepanov-yadro commented 2025-02-12 13:37:17 +00:00
Member
Copy link

Golang SDK uses struct. It is value type, so it can't be nil.

Golang SDK uses struct. It is value type, so it can't be nil.
dstepanov-yadro commented 2025-02-12 13:37:45 +00:00
Member
Copy link

You can do the same by using struct instead of class

You can do the same by using `struct` instead of `class`
PavelGrossSpb commented 2025-02-12 14:05:30 +00:00
Author
Member
Copy link

OK, let it be structs. Done.

OK, let it be structs. Done.
dstepanov-yadro marked this conversation as resolved
src/FrostFS.SDK.Client/ApeRules/RuleSerializer.cs Outdated
@ -0,0 +98,4 @@
private static int ResourcesSize(Resource? resource)
{
return BoolSize // Inverted
+ (resource != null ? SliceSize(resource.Names, StringSize) : 0);
dstepanov-yadro commented 2025-02-12 12:55:57 +00:00
Member
Copy link

Also, if null, then size must be 1. Some unit tests required.

Also, if null, then size must be 1. Some unit tests required.
PavelGrossSpb commented 2025-02-12 13:23:10 +00:00
Author
Member
Copy link

Fixed, see previous comment

Fixed, see previous comment
dstepanov-yadro commented 2025-02-12 14:16:49 +00:00
Member
Copy link

Great! What do you think about some positive/negative unit tests for serializer?

Great! What do you think about some positive/negative unit tests for serializer?
PavelGrossSpb commented 2025-02-12 14:19:15 +00:00
Author
Member
Copy link

I'm working on it, but we've committed to provide this functionality today. So the tests will be some later.

I'm working on it, but we've committed to provide this functionality today. So the tests will be some later.
dstepanov-yadro commented 2025-02-12 14:21:01 +00:00
Member
Copy link

Ok, will test on production. Hardcore!

Ok, will test on production. Hardcore!
dstepanov-yadro marked this conversation as resolved
PavelGrossSpb added 1 commit 2025-02-12 13:18:55 +00:00
[#30] Client: Add object model for Rules, fix for comments
All checks were successful
DCO / DCO (pull_request) Successful in 25s
Details
lint-build / dotnet8.0 (pull_request) Successful in 51s
Details
13da97520d 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb added 1 commit 2025-02-12 14:04:07 +00:00
[#30] Client: Add object model, use structs instead of classes
All checks were successful
DCO / DCO (pull_request) Successful in 25s
Details
lint-build / dotnet8.0 (pull_request) Successful in 43s
Details
a785357268 
Signed-off-by: Pavel Gross <p.gross@yadro.com>
dstepanov-yadro approved these changes 2025-02-12 14:21:07 +00:00
PavelGrossSpb force-pushed apeRules from a785357268 to 195854a45b 2025-02-12 14:29:27 +00:00 Compare
PavelGrossSpb scheduled this pull request to auto merge when all checks succeed 2025-02-12 14:30:18 +00:00
orikik merged commit 195854a45b into master 2025-02-13 07:05:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
orikik
dstepanov-yadro
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-csharp#42
No description provided.
Delete branch "PavelGrossSpb/frostfs-sdk-csharp:apeRules"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?