feature/client_cut_internal #9

Merged
PavelGrossSpb merged 4 commits from PavelGrossSpb/frostfs-sdk-csharp:feature/client_cut_internal into master 2024-06-14 12:07:19 +00:00
Member

Internal implementation for 'client cut' functionality + custom client cut code snippet updating

Internal implementation for 'client cut' functionality + custom client cut code snippet updating
PavelGrossSpb added 2 commits 2024-06-14 09:13:21 +00:00
Signed-off-by: Pavel Gross <p.gross@yadro.com>
Signed-off-by: Pavel Gross <p.gross@yadro.com>
PavelGrossSpb requested review from orikik 2024-06-14 09:13:31 +00:00
PavelGrossSpb requested review from dstepanov-yadro 2024-06-14 09:13:54 +00:00
PavelGrossSpb force-pushed feature/client_cut_internal from b399f5d880 to 6ebf4fb508 2024-06-14 10:09:50 +00:00 Compare
PavelGrossSpb closed this pull request 2024-06-14 10:30:11 +00:00
PavelGrossSpb reopened this pull request 2024-06-14 10:36:21 +00:00
orikik approved these changes 2024-06-14 10:43:19 +00:00
PavelGrossSpb merged commit b69d22966f into master 2024-06-14 12:07:19 +00:00
PavelGrossSpb deleted branch feature/client_cut_internal 2024-06-14 12:07:22 +00:00
dstepanov-yadro requested changes 2024-06-14 12:47:25 +00:00
@ -21,6 +24,8 @@ public partial class Client: IFrostFSClient
public readonly OwnerId OwnerId;
public readonly Version Version = new(2, 13);
private readonly Dictionary<string, ulong> NetworkSettings = [];
`NetworkConfig` contains not only values of `ulong` type. See https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/morph/client/netmap/config.go#L224 or https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/cmd/frostfs-cli/modules/netmap/netinfo.go#L41
@ -88,0 +119,4 @@
_channel = GrpcChannel.ForAddress(uri, new GrpcChannelOptions
{
Credentials = grpcCredentials,
HttpHandler = new System.Net.Http.HttpClientHandler()

For .net framework is WinHttpHandler preferable.
Also it could custom certificate used, so how to specify it now?

For `.net framework` is `WinHttpHandler` preferable. Also it could custom certificate used, so how to specify it now?
@ -84,1 +87,3 @@
private async Task<ObjectId> PutObject(ObjectHeader header, Stream payload)
private Task<ObjectId> PutObject(ObjectHeader header, Stream payload, CancellationToken cancellationToken)
{
if (header.ClientCut)

Actually ClientCut isn't ObjectHeader field.

Actually `ClientCut` isn't `ObjectHeader` field.
@ -85,0 +92,4 @@
return PutStreamObject(header, payload, cancellationToken);
}
private async Task<ObjectId> PutClientCutObject(ObjectHeader header, Stream payloadStream, CancellationToken cancellationToken)

Put and PutSingle are API implementations, but this method looks like client extension from my point of view.

`Put` and `PutSingle` are API implementations, but this method looks like client extension from my point of view.
Sign in to join this conversation.
No description provided.