Support grpc schemas in tree pool #107

New Issue

Closed

opened 2023-07-07 06:42:56 +00:00 by alexvanin · 0 comments

alexvanin commented

2023-07-07 06:42:56 +00:00

Owner

Object service pool instance supports endpoint addresses with grpc:// and grpcs:// schemas. Schemas are allowed due to internal parsing in the SDK Client:

To be compatible with object service configuration, tree pool should support it too.

Describe the solution you'd like

Support grpc:// and grpcs:// schemas prefix in address. If prefix isn't specified, consider grpc://. If scheme is not grpcs:// then provide insecure connection to the endpoint (dial option).

Describe alternatives you've considered

Parse scheme on the application side before calling pool.

Additional context

After this issue, gateways can remove manual insecure option setting

## Is your feature request related to a problem? Please describe. Object service pool instance supports endpoint addresses with `grpc://` and `grpcs://` schemas. Schemas are allowed due to internal parsing in the SDK Client: - [passing address with schema](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/769f6eec0565e4dc3c6b966ed730217739f44ef3/client/client.go#L102) - [parsing schema](https://git.frostfs.info/TrueCloudLab/frostfs-api-go/src/commit/285516a94ebe4c4f1116c01ecd2c73e106e832fd/rpc/client/options.go#L64) To be compatible with object service configuration, tree pool should support it too. ## Describe the solution you'd like Support `grpc://` and `grpcs://` schemas prefix in address. If prefix isn't specified, consider `grpc://`. If scheme is not `grpcs://` then provide insecure connection to the endpoint (dial option). ## Describe alternatives you've considered Parse scheme on the application side before calling pool. ## Additional context After this issue, gateways can remove manual [insecure option setting](https://git.frostfs.info/TrueCloudLab/frostfs-s3-gw/src/commit/7f708b3a2d656582ed136361b805fe0da20b77df/cmd/s3-gw/app.go#L316)