feature/107-support_schemas_in_tree_pool #108

dkirillov · 2023-07-07T10:01:13Z

dkirillov commented

2023-07-07 10:01:13 +00:00

close #107

dkirillov self-assigned this 2023-07-07 10:01:13 +00:00

dkirillov force-pushed feature/107-support_schemas_in_tree_pool from 37f830d665 to a06979b766

2023-07-07 10:02:10 +00:00

Compare

dkirillov changed title from ~~WIP: feature/107-support_schemas_in_tree_pool~~ to feature/107-support_schemas_in_tree_pool

2023-07-07 11:24:23 +00:00

dkirillov requested review from storage-services-developers 2023-07-07 11:24:29 +00:00

dkirillov requested review from storage-services-committers 2023-07-07 11:24:30 +00:00

dkirillov requested review from storage-core-developers 2023-07-07 11:24:30 +00:00

dkirillov requested review from storage-core-committers 2023-07-07 11:24:30 +00:00

alexvanin reviewed 2023-07-07 11:29:30 +00:00

pool/tree/client.go Outdated

					
				@ -77,0 +82,4 @@

					if !tlsEnable {

						opts = append(opts, grpc.WithTransportCredentials(insecure.NewCredentials()))

					} else {

						opts = append(opts, grpc.WithTransportCredentials(credentials.NewTLS(&tls.Config{})))

alexvanin commented

2023-07-07 11:28:35 +00:00

If I understand correctly, those appends will override any transport credentials parameters from opts. I suggest to do the opposite and allow opts to override those default transport credentials.

If I understand correctly, those appends will override any transport credentials parameters from `opts`. I suggest to do the opposite and allow `opts` to override those default transport credentials.

👍 1