TrueCloudLab
/
frostfs-sdk-go
29
0
Fork 18
Code Issues 29 Pull Requests 3 Actions Releases Activity

Make PrmDial, PrmInit like public field structs to init and dial Client #189

New Issue
Closed
opened 2023-11-02 07:36:45 +00:00 by aarifullin · 1 comment
aarifullin commented 2023-11-02 07:36:45 +00:00
Collaborator

It is the same idea as for #121.
This implies to make fields public for PrmDial and PrmInit and make setters deprecated.
After that we can instantly pass init and dial params to methods Init and Dial

It is the same idea as for [#121](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/121). This implies to make fields public for `PrmDial` and `PrmInit` and make setters deprecated. After that we can instantly pass init and dial params to methods [Init](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/6fbe1595cb3d1fbc28403c5fafae2c14e343475f/client/client.go#L61) and [Dial](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/6fbe1595cb3d1fbc28403c5fafae2c14e343475f/client/client.go#L80)
aarifullin added the
discussion
refactoring
 labels 2023-11-02 07:36:45 +00:00
aarifullin added the
good first issue
 label 2023-11-02 09:14:05 +00:00
aarifullin commented 2023-11-21 13:06:53 +00:00
Poster
Collaborator

Refactored

Refactored
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
support/v1.0.0-rc.4
master
support/v1.0.0-rc.3
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers   
pool

Tasks related to client pool
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#189
There is no content yet.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?