TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

client: Make PrmDial, PrmInit fields public and make setters deprecated #193

Merged
fyrchik merged 2 commits from aarifullin/frostfs-sdk-go:feature/189-prm_dial into master 2024-09-04 19:51:15 +00:00
Conversation 0 Commits 2 Files changed 21 +106 -91
aarifullin commented 2023-11-13 12:37:51 +00:00
Member
Copy link

This PR is initiated by the issue #189

This PR is initiated by the issue [#189](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/189)
aarifullin added the
discussion
refactoring
 labels 2023-11-13 12:37:51 +00:00
aarifullin added 1 commit 2023-11-13 12:37:53 +00:00 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin requested review from storage-core-committers 2023-11-13 12:38:12 +00:00
aarifullin requested review from storage-core-developers 2023-11-13 12:38:13 +00:00
aarifullin requested review from storage-services-committers 2023-11-13 12:38:23 +00:00
aarifullin requested review from storage-services-developers 2023-11-13 12:38:23 +00:00
dstepanov-yadro approved these changes 2023-11-13 13:00:14 +00:00
acid-ant approved these changes 2023-11-13 13:34:46 +00:00
fyrchik reviewed 2023-11-14 06:53:09 +00:00
client/client.go Outdated
@ -88,3 +88,3 @@
}
} else {
prm.timeoutDial = 5 * time.Second
prm.DialTimeout = new(time.Duration)
fyrchik commented 2023-11-14 06:51:54 +00:00
Owner
Copy link

Do we really want a pointer here? It is a primitive type, <= 0 value can be transform to a default. These 2 lines you wrote will also be needed on the caller side, and they are quite annoying TBH

Do we really want a pointer here? It is a primitive type, `<= 0` value can be transform to a default. These 2 lines you wrote will also be needed on the caller side, and they are quite annoying TBH
aarifullin commented 2023-11-14 08:14:22 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
client/client.go Outdated
@ -178,2 +185,3 @@
// Deprecated: Use PrmInit.ResponseInfoCallback instead.
func (x *PrmInit) SetResponseInfoCallback(f func(ResponseMetaInfo) error) {
x.cbRespInfo = f
x.ResponseInfoCallback = f
fyrchik commented 2023-11-14 06:52:57 +00:00
Owner
Copy link

I have not checked this after refactoring, but is it still used?

I have not checked this after refactoring, but is it still used?
aarifullin commented 2023-11-14 08:13:54 +00:00
Author
Member
Copy link

If you are asking whether SetResponseInfoCallback is used somewhere - yes, it is:

Line 76 in TrueCloudLab/frostfs-node@8088063
prmInit.SetResponseInfoCallback(x.opts.ResponseCallback)

If you are asking whether `SetResponseInfoCallback` is used somewhere - yes, it is: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/8088063195f971d10ad7bb7bf5497b214000c5ec/pkg/network/cache/multi.go#L76
fyrchik marked this conversation as resolved
aarifullin force-pushed feature/189-prm_dial from 048cc4ff53 to ae7b3bf97b 2023-11-14 08:14:18 +00:00 Compare
aarifullin requested review from acid-ant 2023-11-14 08:14:57 +00:00
aarifullin requested review from dstepanov-yadro 2023-11-14 08:15:01 +00:00
aarifullin force-pushed feature/189-prm_dial from ae7b3bf97b to 3787477133 2023-11-14 08:18:09 +00:00 Compare
fyrchik approved these changes 2023-11-14 08:26:39 +00:00
fyrchik merged commit 3787477133 into master 2023-11-14 08:27:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#193
No description provided.
Delete branch "aarifullin/frostfs-sdk-go:feature/189-prm_dial"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?