TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

client/put_transformer: Fix error handling #210

Merged
fyrchik merged 1 commit from achuprov/frostfs-sdk-go:bugfix/put_ignoring_errors into master 2024-03-20 09:47:30 +00:00
Conversation 0 Commits 1 Files changed 1 +4
achuprov commented 2024-03-19 12:54:52 +00:00
Member
Copy link

Currently, the Close method does not handle errors occurring during WritePayloadChunk execution.
This is similar to the implementation already in place for object_put_raw.

Ref: TrueCloudLab/frostfs-node#1041
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Currently, the `Close` method does not handle errors occurring during `WritePayloadChunk` execution. This is similar to the implementation already in place for [object_put_raw](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/edd40474e89ad11aeb6c94b736555700764b00f8/client/object_put_raw.go#L150). Ref: https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/1041 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2024-03-19 12:54:53 +00:00
[#210] client/put_transformer: Fix error handling
All checks were successful
DCO / DCO (pull_request) Successful in 1m1s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m17s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m29s
Details
Tests and linters / Lint (pull_request) Successful in 2m39s
Details
6f248436a5 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from storage-core-committers 2024-03-19 13:00:57 +00:00
achuprov requested review from storage-core-developers 2024-03-19 13:00:58 +00:00
fyrchik approved these changes 2024-03-19 13:07:10 +00:00
aarifullin approved these changes 2024-03-20 09:42:14 +00:00
fyrchik merged commit 6f248436a5 into master 2024-03-20 09:47:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#210
No description provided.
Delete branch "achuprov/frostfs-sdk-go:bugfix/put_ignoring_errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?