TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 30 Pull requests 3 Releases Activity Actions

Upgrade google.golang.org/grpc and frostfs-api-go version #270

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-sdk-go:feat/upgrade-grpc into master 2024-11-02 14:21:45 +00:00
Conversation 0 Commits 1 Files changed 1 +14 -4
dstepanov-yadro commented 2024-09-16 12:09:23 +00:00
Member
Copy link

For tree pool grpc.DialContext replaced to grpc.NewClient as right after client creation Healthcheck RPC performed.

After api-go upgrade created client doesn't establish connection after created, so RPC call is required to establish and check connection.
RPC call returns status error, so conversion from status error to context error is required to satisfy Dial contract and unit tests.

For tree pool `grpc.DialContext` replaced to `grpc.NewClient` as right after client creation `Healthcheck` RPC performed. After api-go upgrade created client doesn't establish connection after created, so RPC call is required to establish and check connection. RPC call returns status error, so conversion from status error to context error is required to satisfy Dial contract and unit tests.
dstepanov-yadro added 4 commits 2024-09-16 12:09:23 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
`Healthcheck` request performed after client creation, so no extra RPC required.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] client: Drop TODO about dial
Some checks failed
DCO / DCO (pull_request) Successful in 37s
Details
Tests and linters / Tests (pull_request) Failing after 54s
Details
Tests and linters / Lint (pull_request) Successful in 1m52s
Details
f642c79a25 
Since `grpc.NewClient` method is now being used, a RPC call must be made
to actually establish the connection.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/upgrade-grpc from f642c79a25 to cdcb18fcee 2024-09-16 12:10:31 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-09-16 12:11:19 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-09-16 12:11:19 +00:00
dstepanov-yadro requested review from storage-services-committers 2024-09-16 12:11:27 +00:00
dstepanov-yadro requested review from storage-services-developers 2024-09-16 12:11:27 +00:00
dstepanov-yadro changed title from Upgrade google.golang.org/grpc and frostfs-api-go version to WIP: Upgrade google.golang.org/grpc and frostfs-api-go version 2024-09-16 12:12:59 +00:00
dstepanov-yadro force-pushed feat/upgrade-grpc from cdcb18fcee to 2148a27ded 2024-09-16 12:30:57 +00:00 Compare
dstepanov-yadro force-pushed feat/upgrade-grpc from 2148a27ded to 6009d089fc 2024-09-16 12:32:05 +00:00 Compare
dstepanov-yadro changed title from WIP: Upgrade google.golang.org/grpc and frostfs-api-go version to Upgrade google.golang.org/grpc and frostfs-api-go version 2024-09-16 12:36:21 +00:00
aarifullin approved these changes 2024-09-16 12:40:35 +00:00
alexvanin approved these changes 2024-09-18 06:29:21 +00:00
dstepanov-yadro merged commit 6009d089fc into master 2024-09-18 08:43:49 +00:00
dstepanov-yadro deleted branch feat/upgrade-grpc 2024-09-18 08:43:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
alexvanin
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#270
No description provided.
Delete branch "dstepanov-yadro/frostfs-sdk-go:feat/upgrade-grpc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?