Upgrade google.golang.org/grpc and frostfs-api-go version #270

Merged
dstepanov-yadro merged 4 commits from dstepanov-yadro/frostfs-sdk-go:feat/upgrade-grpc into master 2024-11-02 14:21:45 +00:00

For tree pool grpc.DialContext replaced to grpc.NewClient as right after client creation Healthcheck RPC performed.

After api-go upgrade created client doesn't establish connection after created, so RPC call is required to establish and check connection.
RPC call returns status error, so conversion from status error to context error is required to satisfy Dial contract and unit tests.

For tree pool `grpc.DialContext` replaced to `grpc.NewClient` as right after client creation `Healthcheck` RPC performed. After api-go upgrade created client doesn't establish connection after created, so RPC call is required to establish and check connection. RPC call returns status error, so conversion from status error to context error is required to satisfy Dial contract and unit tests.
dstepanov-yadro added 4 commits 2024-09-16 12:09:23 +00:00
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
`Healthcheck` request performed after client creation, so no extra RPC required.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] client: Drop TODO about dial
Some checks failed
DCO / DCO (pull_request) Successful in 37s
Tests and linters / Tests (pull_request) Failing after 54s
Tests and linters / Lint (pull_request) Successful in 1m52s
f642c79a25
Since `grpc.NewClient` method is now being used, a RPC call must be made
to actually establish the connection.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/upgrade-grpc from f642c79a25 to cdcb18fcee 2024-09-16 12:10:31 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-09-16 12:11:19 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-09-16 12:11:19 +00:00
dstepanov-yadro requested review from storage-services-committers 2024-09-16 12:11:27 +00:00
dstepanov-yadro requested review from storage-services-developers 2024-09-16 12:11:27 +00:00
dstepanov-yadro changed title from Upgrade google.golang.org/grpc and frostfs-api-go version to WIP: Upgrade google.golang.org/grpc and frostfs-api-go version 2024-09-16 12:12:59 +00:00
dstepanov-yadro force-pushed feat/upgrade-grpc from cdcb18fcee to 2148a27ded 2024-09-16 12:30:57 +00:00 Compare
dstepanov-yadro force-pushed feat/upgrade-grpc from 2148a27ded to 6009d089fc 2024-09-16 12:32:05 +00:00 Compare
dstepanov-yadro changed title from WIP: Upgrade google.golang.org/grpc and frostfs-api-go version to Upgrade google.golang.org/grpc and frostfs-api-go version 2024-09-16 12:36:21 +00:00
aarifullin approved these changes 2024-09-16 12:40:35 +00:00
alexvanin approved these changes 2024-09-18 06:29:21 +00:00
dstepanov-yadro merged commit 6009d089fc into master 2024-09-18 08:43:49 +00:00
dstepanov-yadro deleted branch feat/upgrade-grpc 2024-09-18 08:43:50 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-services-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#270
No description provided.