client: Close connection on non-nil error in Dial #282

Merged

fyrchik merged 1 commit from fyrchik/frostfs-sdk-go:fix-connection-close into master

2024-10-10 11:57:08 +00:00

fyrchik commented

2024-10-10 11:03:16 +00:00

Owner

A particular status code does not imply that connection has not been
established. However, Dial() requires user to call Close() only if
the error was nil. Thus, it is Dial() responsibility to close
everything if it returns an error.

Introduced after the gRPC update in #270 (6009d089fc).

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

A particular status code does not imply that connection has not been established. However, `Dial()` requires user to call `Close()` only if the error was nil. Thus, it is `Dial()` responsibility to close everything if it returns an error. Introduced after the gRPC update in #270 (6009d089fc69). Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik added 1 commit 2024-10-10 11:03:17 +00:00

client: Close connection on non-nil error in Dial

DCO / DCO (pull_request) Failing after 36s

Details

Tests and linters / Tests (pull_request) Successful in 1m36s

Details

Tests and linters / Lint (pull_request) Successful in 2m7s

Details

29be703a71

A particular status code does not imply that connection has not been
established. However, `Dial()` requires user to call `Close()` only if
the error was nil. Thus, it is `Dial()` responsibility to close
everything if it returns an error.

Introduced after the gRPC update in #270 (6009d089fc).

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik force-pushed fix-connection-close from 29be703a71 to 1b1adb9600

2024-10-10 11:03:35 +00:00

Compare

fyrchik requested review from storage-core-committers 2024-10-10 11:03:36 +00:00

fyrchik requested review from storage-core-developers 2024-10-10 11:03:37 +00:00

fyrchik force-pushed fix-connection-close from 1b1adb9600 to 99c5c58365

2024-10-10 11:04:17 +00:00

Compare

fyrchik requested review from storage-services-committers 2024-10-10 11:04:24 +00:00

fyrchik requested review from storage-services-developers 2024-10-10 11:04:27 +00:00