TrueCloudLab/frostfs-sdk-go

Fork 21

client: Return status from all methods #285

Merged

fyrchik merged 1 commit from mbiryukova/frostfs-sdk-go:bugfix/client_status_v1.0.0-rc.5 into support/v1.0.0-rc.5

2024-10-17 07:15:46 +00:00

mbiryukova commented

2024-10-16 10:16:15 +00:00

Member

Since status is checked first in handleError method, it should be returned from client methods

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Since status is checked first in handleError method, it should be returned from client methods Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova self-assigned this 2024-10-16 10:16:15 +00:00

mbiryukova added 1 commit 2024-10-16 10:16:15 +00:00

[#xxx] client: Return status from all methods

DCO / DCO (pull_request) Failing after 45s

Details

Tests and linters / Tests (pull_request) Successful in 1m17s

Details

Tests and linters / Lint (pull_request) Successful in 3m8s

Details

9e67c471df

Since status is checked first in handleError method, it should be returned from client methods

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>

mbiryukova force-pushed bugfix/client_status_v1.0.0-rc.5 from 9e67c471df to 0a0d659a4e

2024-10-16 10:19:02 +00:00

Compare

mbiryukova changed title from ~~[#xxx] client: Return status from all methods~~ to [#285] client: Return status from all methods

2024-10-16 10:20:51 +00:00

mbiryukova requested review from storage-core-committers 2024-10-16 10:26:10 +00:00

mbiryukova requested review from storage-core-developers 2024-10-16 10:26:11 +00:00

mbiryukova requested review from storage-sdk-committers 2024-10-16 10:26:12 +00:00

mbiryukova requested review from storage-sdk-developers 2024-10-16 10:26:14 +00:00

mbiryukova requested review from storage-services-committers 2024-10-16 10:26:15 +00:00

mbiryukova requested review from storage-services-developers 2024-10-16 10:26:15 +00:00

acid-ant changed title from ~~[#285] client: Return status from all methods~~ to client: Return status from all methods

2024-10-16 10:51:56 +00:00

dkirillov approved these changes 2024-10-16 11:27:34 +00:00

fyrchik commented

2024-10-16 15:36:21 +00:00

Owner

Since status is checked first in handleError method, it should be returned from client methods

One could argue that since client doesn't return status on error, handleError() should be rewritten.
Not opposing the change, but the main reason is consistency -- it seems other method are used the same pattern you introduce here.
Could you explain this in the commit description, please?

>Since status is checked first in handleError method, it should be returned from client methods One could argue that since client doesn't return status on error, `handleError()` should be rewritten. Not opposing the change, but the main reason is consistency -- it seems other method are used the same pattern you introduce here. Could you explain this in the commit description, please?

fyrchik commented

2024-10-16 15:36:43 +00:00

Owner

Also, this goes to rc.5 branch, what is the bug we need to fix there?

Also, this goes to `rc.5` branch, what is the bug we need to fix there?

dkirillov commented

2024-10-17 06:46:02 +00:00

Member

It's port #275
Original issue #253

It's port https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/275 Original issue https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/253