TrueCloudLab/frostfs-sdk-go
30
0
Fork 20
Code Issues 30 Pull requests 2 Releases Activity Actions

[#253] pool: Don't count regular FrostFS errors #253

Merged
dkirillov merged 1 commit from dkirillov/frostfs-sdk-go:bugfix/dont_count_eacl_not_found_error into master 2024-08-14 14:36:30 +00:00
Conversation 0 Commits 1 Files changed 2 +34 -10
dkirillov commented 2024-08-14 13:48:29 +00:00
Member
Copy link

Previously we count all frostfs errors like:
ObjectNotFound, EACLNotFound
because frostfs status is unconditionally resolved into built-in go errors
but handleError method handled built-in errors like internal network ones.
Since after resolving frostfs errors status is also returned we start check this first

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Previously we count all frostfs errors like: ObjectNotFound, EACLNotFound because frostfs status is unconditionally resolved into built-in go errors but handleError method handled built-in errors like internal network ones. Since after resolving frostfs errors status is also returned we start check this first Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-08-14 13:48:30 +00:00
dkirillov added 1 commit 2024-08-14 13:48:34 +00:00
[#XX] pool: Don't count regular FrostFS errors
Some checks failed
DCO / DCO (pull_request) Failing after 56s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m4s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 1m2s
Details
Tests and linters / Lint (pull_request) Successful in 1m37s
Details
8ea5f2b03f 
Previously we count all frostfs errors like:
ObjectNotFound, EACLNotFound
because frostfs status is unconditionally resolved into built-in go errors
but handleError method handled built-in errors like internal network ones.
Since after resolving frostfs errors status is also returned we start check this first

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov changed title from WIP: [#XX] pool: Don't count regular FrostFS errors to WIP: [#253] pool: Don't count regular FrostFS errors 2024-08-14 13:48:42 +00:00
dkirillov force-pushed bugfix/dont_count_eacl_not_found_error from 8ea5f2b03f to 203bba65a0 2024-08-14 13:49:01 +00:00 Compare
dkirillov changed title from WIP: [#253] pool: Don't count regular FrostFS errors to [#253] pool: Don't count regular FrostFS errors 2024-08-14 13:49:07 +00:00
dkirillov requested review from storage-services-developers 2024-08-14 13:49:18 +00:00
dkirillov requested review from storage-services-committers 2024-08-14 13:49:20 +00:00
dkirillov requested review from storage-sdk-developers 2024-08-14 13:49:21 +00:00
dkirillov requested review from storage-sdk-committers 2024-08-14 13:49:23 +00:00
dkirillov requested review from storage-core-developers 2024-08-14 13:49:26 +00:00
dkirillov requested review from storage-core-committers 2024-08-14 13:49:26 +00:00
dkirillov added the
bug
 label 2024-08-14 13:51:53 +00:00
BrookDaniel approved these changes 2024-08-14 14:07:59 +00:00
pogpp approved these changes 2024-08-14 14:10:00 +00:00
mbiryukova approved these changes 2024-08-14 14:10:06 +00:00
r.loginov approved these changes 2024-08-14 14:11:37 +00:00
elebedeva approved these changes 2024-08-14 14:31:20 +00:00
aarifullin approved these changes 2024-08-14 14:32:00 +00:00
acid-ant approved these changes 2024-08-14 14:35:21 +00:00
dkirillov merged commit 203bba65a0 into master 2024-08-14 14:36:30 +00:00
dkirillov deleted branch bugfix/dont_count_eacl_not_found_error 2024-08-14 14:36:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
BrookDaniel
pogpp
mbiryukova
r.loginov
elebedeva
aarifullin
acid-ant
TrueCloudLab/storage-sdk-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
8 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#253
No description provided.
Delete branch "dkirillov/frostfs-sdk-go:bugfix/dont_count_eacl_not_found_error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?