[#253] pool: Don't count regular FrostFS errors #253

Merged
dkirillov merged 1 commit from dkirillov/frostfs-sdk-go:bugfix/dont_count_eacl_not_found_error into master 2024-08-14 14:36:30 +00:00
Member

Previously we count all frostfs errors like:
ObjectNotFound, EACLNotFound
because frostfs status is unconditionally resolved into built-in go errors
but handleError method handled built-in errors like internal network ones.
Since after resolving frostfs errors status is also returned we start check this first

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Previously we count all frostfs errors like: ObjectNotFound, EACLNotFound because frostfs status is unconditionally resolved into built-in go errors but handleError method handled built-in errors like internal network ones. Since after resolving frostfs errors status is also returned we start check this first Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-08-14 13:48:30 +00:00
dkirillov added 1 commit 2024-08-14 13:48:34 +00:00
[#XX] pool: Don't count regular FrostFS errors
Some checks failed
DCO / DCO (pull_request) Failing after 56s
Tests and linters / Tests (1.21) (pull_request) Successful in 1m4s
Tests and linters / Tests (1.22) (pull_request) Successful in 1m2s
Tests and linters / Lint (pull_request) Successful in 1m37s
8ea5f2b03f
Previously we count all frostfs errors like:
ObjectNotFound, EACLNotFound
because frostfs status is unconditionally resolved into built-in go errors
but handleError method handled built-in errors like internal network ones.
Since after resolving frostfs errors status is also returned we start check this first

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov changed title from WIP: [#XX] pool: Don't count regular FrostFS errors to WIP: [#253] pool: Don't count regular FrostFS errors 2024-08-14 13:48:42 +00:00
dkirillov force-pushed bugfix/dont_count_eacl_not_found_error from 8ea5f2b03f to 203bba65a0 2024-08-14 13:49:01 +00:00 Compare
dkirillov changed title from WIP: [#253] pool: Don't count regular FrostFS errors to [#253] pool: Don't count regular FrostFS errors 2024-08-14 13:49:07 +00:00
dkirillov requested review from storage-services-developers 2024-08-14 13:49:18 +00:00
dkirillov requested review from storage-services-committers 2024-08-14 13:49:20 +00:00
dkirillov requested review from storage-sdk-developers 2024-08-14 13:49:21 +00:00
dkirillov requested review from storage-sdk-committers 2024-08-14 13:49:23 +00:00
dkirillov requested review from storage-core-developers 2024-08-14 13:49:26 +00:00
dkirillov requested review from storage-core-committers 2024-08-14 13:49:26 +00:00
dkirillov added the
bug
label 2024-08-14 13:51:53 +00:00
BrookDaniel approved these changes 2024-08-14 14:07:59 +00:00
pogpp approved these changes 2024-08-14 14:10:00 +00:00
mbiryukova approved these changes 2024-08-14 14:10:06 +00:00
r.loginov approved these changes 2024-08-14 14:11:37 +00:00
elebedeva approved these changes 2024-08-14 14:31:20 +00:00
aarifullin approved these changes 2024-08-14 14:32:00 +00:00
acid-ant approved these changes 2024-08-14 14:35:21 +00:00
dkirillov merged commit 203bba65a0 into master 2024-08-14 14:36:30 +00:00
dkirillov deleted branch bugfix/dont_count_eacl_not_found_error 2024-08-14 14:36:33 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-sdk-developers
No milestone
No project
No assignees
8 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#253
No description provided.