TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

[#37] feature/use_new_system_attributes #37

Merged
fyrchik merged 1 commit from dkirillov/frostfs-sdk-go:feature/use_new_system_attributes into master 2023-07-26 21:08:02 +00:00
Conversation 0 Commits 1 Files changed 1 +6 -3
dkirillov commented 2023-03-16 08:13:54 +00:00
Member
Copy link

Note: in this PR we don't support legacy __NEOFS__ attributes in storage groups and subnet because these packages are going to be deleted

**Note:** in this PR we don't support legacy `__NEOFS__` attributes in storage groups and subnet because these packages are going to be deleted
dkirillov self-assigned this 2023-03-16 08:13:54 +00:00
dkirillov changed title from WIP: [#XX] feature/use_new_system_attributes to WIP: [#37] feature/use_new_system_attributes 2023-03-16 08:14:02 +00:00
dkirillov force-pushed feature/use_new_system_attributes from c50aba62c4 to bec77f280a 2023-03-16 08:15:01 +00:00 Compare
dkirillov changed title from WIP: [#37] feature/use_new_system_attributes to [#37] feature/use_new_system_attributes 2023-03-16 08:16:30 +00:00
dkirillov requested review from storage-core-committers 2023-03-16 08:16:39 +00:00
dkirillov requested review from storage-core-developers 2023-03-16 08:16:39 +00:00
dkirillov requested review from storage-services-committers 2023-03-16 08:16:39 +00:00
dkirillov requested review from storage-services-developers 2023-03-16 08:16:39 +00:00
alexvanin reviewed 2023-03-16 08:48:47 +00:00
go.mod
@ -15,6 +15,7 @@ require (
github.com/stretchr/testify v1.8.1
go.uber.org/atomic v1.10.0
go.uber.org/zap v1.24.0
google.golang.org/grpc v1.48.0
alexvanin commented 2023-03-16 08:48:41 +00:00
Owner
Copy link

New direct dependency?

New direct dependency?
dkirillov commented 2023-03-16 11:06:54 +00:00
Author
Member
Copy link

Not really, It seems this is forgotten dependency from #17

Not really, It seems this is forgotten dependency from https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/17
alexvanin marked this conversation as resolved
alexvanin approved these changes 2023-03-16 11:40:14 +00:00
fyrchik approved these changes 2023-03-21 09:16:51 +00:00
container/container.go
@ -469,3 +469,3 @@
if name != "" {
if name := cnr.Attribute(container.SysAttributeName); name != "" {
res.SetName(name)
res.SetZone(cnr.Attribute(container.SysAttributeZone))
fyrchik commented 2023-03-21 09:16:37 +00:00
Owner
Copy link

So we both Name + Zone must be the same (deprecated or not)?

So we both `Name` + `Zone` must be the same (deprecated or not)?
dkirillov commented 2023-03-21 09:30:03 +00:00
Author
Member
Copy link

Yes

Yes
fyrchik merged commit bec77f280a into master 2023-03-21 09:16:57 +00:00
dkirillov deleted branch feature/use_new_system_attributes 2023-03-21 09:26:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#37
No description provided.
Delete branch "dkirillov/frostfs-sdk-go:feature/use_new_system_attributes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?