TrueCloudLab/frostfs-sdk-go
30
0
Fork 20
Code Issues 30 Pull requests 1 Releases Activity Actions

Add PutSingle method for object service #103

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-sdk-go:feat/put-single into master 2023-07-26 21:08:02 +00:00
Conversation 1 Commits 1 Files changed 2 +163 -7
dstepanov-yadro commented 2023-07-05 07:59:41 +00:00
Member
Copy link

Relates TrueCloudLab/frostfs-api#9

Relates https://git.frostfs.info/TrueCloudLab/frostfs-api/issues/9
dstepanov-yadro force-pushed feat/put-single from 032b9cd838 to f4482d392c 2023-07-05 08:01:13 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-07-05 08:21:43 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-07-05 08:21:43 +00:00
dstepanov-yadro force-pushed feat/put-single from 5a464411fa to 6cd2658879 2023-07-05 15:11:27 +00:00 Compare
acid-ant approved these changes 2023-07-06 08:06:23 +00:00
fyrchik approved these changes 2023-07-06 09:18:48 +00:00
client/object_put_transformer.go Outdated
@ -84,0 +81,4 @@
prm.UseKey(prm.key)
prm.meta = it.prm.meta
res, err := it.client.ObjectPutSingle(ctx, prm)
fyrchik commented 2023-07-06 09:18:45 +00:00
Owner
Copy link

What about fallback to the old implementation? Can we do something sane here?

What about fallback to the old implementation? Can we do something sane here?
dstepanov-yadro commented 2023-07-06 14:06:54 +00:00
Author
Member
Copy link

Done

Done
dstepanov-yadro force-pushed feat/put-single from 6cd2658879 to 98cab7ed61 2023-07-06 14:06:37 +00:00 Compare
dstepanov-yadro requested review from acid-ant 2023-07-06 14:06:58 +00:00
dstepanov-yadro requested review from fyrchik 2023-07-06 14:07:00 +00:00
dstepanov-yadro commented 2023-07-06 14:07:36 +00:00
Author
Member
Copy link

fallback to stream put added, @acid-ant @fyrchik review plz again

fallback to stream put added, @acid-ant @fyrchik review plz again
fyrchik approved these changes 2023-07-06 15:53:17 +00:00
acid-ant approved these changes 2023-07-07 05:30:42 +00:00
dstepanov-yadro merged commit 98cab7ed61 into master 2023-07-07 08:25:40 +00:00
dstepanov-yadro deleted branch feat/put-single 2023-07-07 08:25:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#103
No description provided.
Delete branch "dstepanov-yadro/frostfs-sdk-go:feat/put-single"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?