TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 34 Pull requests 2 Releases Activity Actions

transformer: Simplify interface #110

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-sdk-go:feat/refactor-transformer into master 2023-07-11 07:33:13 +00:00
Conversation 0 Commits 1 Files changed 6 +52 -112
dstepanov-yadro commented 2023-07-07 12:36:40 +00:00
Member
Copy link

Use simple WriteObject method to actually write object.

Closes #64

Use simple `WriteObject` method to actually write object. Closes #64
dstepanov-yadro requested review from storage-core-committers 2023-07-07 12:37:01 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-07-07 12:37:02 +00:00
fyrchik reviewed 2023-07-10 11:24:01 +00:00
client/object_put_transformer.go Outdated
@ -80,3 +67,1 @@
it.current.SetPayload(it.payload)
putSingleImplemented, err := it.tryPutSingle(ctx)
func (it *internalTarget) WriteObject(ctx context.Context, o *object.Object) (*transformer.AccessIdentifiers, error) {
fyrchik commented 2023-07-10 11:21:57 +00:00
Owner
Copy link

Here we write a prepared object, do we need this transformer.AccessIdentifiers in the return value?

Here we write a prepared object, do we need this `transformer.AccessIdentifiers` in the return value?
dstepanov-yadro commented 2023-07-10 11:45:09 +00:00
Author
Member
Copy link

No, fixed

No, fixed
fyrchik marked this conversation as resolved
object/transformer/transformer_test.go Outdated
@ -199,2 +179,3 @@
tt.current.SetPayload(tt.payload)
func (tt *testTarget) WriteObject(_ context.Context, o *objectSDK.Object) (*AccessIdentifiers, error) {
tt.current = o
tt.objects = append(tt.objects, tt.current)
fyrchik commented 2023-07-10 11:23:38 +00:00
Owner
Copy link

So, it's just tt.objects = append(tt.object, o)? We set current to nil afterwards.

So, it's just `tt.objects = append(tt.object, o)`? We set current to `nil` afterwards.
dstepanov-yadro commented 2023-07-10 11:45:17 +00:00
Author
Member
Copy link

Oops, fixed

Oops, fixed
fyrchik marked this conversation as resolved
object/transformer/types.go Outdated
@ -25,1 +24,3 @@
type ObjectTarget interface {
// ObjectChunkWriter is an interface of the object writer
// that writes object chunked.
type ObjectChunkWriter interface {
fyrchik commented 2023-07-10 11:23:59 +00:00
Owner
Copy link

UnpreparedObjectWriter?

`UnpreparedObjectWriter`?
dstepanov-yadro commented 2023-07-10 11:47:09 +00:00
Author
Member
Copy link

I don't understand what does Unprepared mean? WriteHeader requires objectSDK.Object, so actually I have to prepare object to use this interface.

Renamed to ChunkedObjectWriter, it looks closer to the truth.

I don't understand what does `Unprepared` mean? `WriteHeader` requires `objectSDK.Object`, so actually I have to prepare object to use this interface. Renamed to `ChunkedObjectWriter`, it looks closer to the truth.
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/refactor-transformer from 182afc2913 to 272118af2c 2023-07-10 11:44:59 +00:00 Compare
fyrchik approved these changes 2023-07-10 17:14:06 +00:00
aarifullin reviewed 2023-07-11 07:12:52 +00:00
object/transformer/channel.go
@ -38,3 +21,1 @@
if len(c.payload) != 0 {
c.header.SetPayload(slice.Copy(c.payload))
}
func (c *chanTarget) WriteObject(ctx context.Context, o *objectSDK.Object) error {
aarifullin commented 2023-07-11 07:12:52 +00:00
Member
Copy link

Could you please put interface implementation check

var _ ObjectWriter = (chanTarget*)(nil)
Could you please put interface implementation check ``` var _ ObjectWriter = (chanTarget*)(nil) ```
aarifullin approved these changes 2023-07-11 07:14:52 +00:00
fyrchik merged commit c359a7465a into master 2023-07-11 07:33:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#110
No description provided.
Delete branch "dstepanov-yadro/frostfs-sdk-go:feat/refactor-transformer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?