[#xx] Add support for SELECT-FILTER expressions #118

ale64bit · 2023-07-13T13:29:11Z

ale64bit commented

2023-07-13 13:29:11 +00:00

This will allow the policy playground command to evaluate FILTERs and SELECTors independently, to better understand their effect and build policies incrementally.

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

This will allow the policy playground command to evaluate `FILTER`s and `SELECT`ors independently, to better understand their effect and build policies incrementally. Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>

ale64bit changed title from ~~[#xx] Add support for SELECT-FILTER expressions~~ to WIP: [#xx] Add support for SELECT-FILTER expressions

2023-07-13 13:29:19 +00:00

ale64bit changed title from ~~WIP: [#xx] Add support for SELECT-FILTER expressions~~ to [#xx] Add support for SELECT-FILTER expressions

2023-07-13 13:29:30 +00:00

ale64bit requested review from storage-core-committers 2023-07-13 13:29:43 +00:00

ale64bit requested review from storage-core-developers 2023-07-13 13:29:43 +00:00

ale64bit added the

discussion

label 2023-07-14 07:05:13 +00:00

dstepanov-yadro reviewed 2023-07-14 07:29:09 +00:00

netmap/parser/query_base_visitor.go Outdated

					
				@ -1,4 +1,4 @@

				// Code generated from Query.g4 by ANTLR 4.13.0. DO NOT EDIT.

				// Code generated from /home/alopez/src/frostfs-sdk-go/netmap/parser/Query.g4 by ANTLR 4.13.0. DO NOT EDIT.

dstepanov-yadro commented

2023-07-14 07:29:09 +00:00

looks redundant)

ale64bit commented

2023-07-14 07:38:01 +00:00

fixed.

It looks like this is generated when make policy is used, but not when go generate ./... is used. We should probably fix this.

fixed. It looks like this is generated when `make policy` is used, but not when `go generate ./...` is used. We should probably fix this.

dstepanov-yadro approved these changes 2023-07-14 07:30:14 +00:00

ale64bit force-pushed feature/select-filter-expr from 9ac75c07cc to 6ba1adfa07

2023-07-14 07:37:10 +00:00

Compare

fyrchik commented

2023-07-17 09:27:49 +00:00

Could you elaborate, how it helps?
I mean we can (?) decode SELECT/FILTER separately, and a separate root terminal will introduce some branching in the CLI anyway, so what is the benefit?

Could you elaborate, how it helps? I mean we can (?) decode SELECT/FILTER separately, and a separate root terminal will introduce some branching in the CLI anyway, so what is the benefit?

fyrchik approved these changes 2023-07-17 10:29:43 +00:00

fyrchik merged commit b91f9d8c79 into master

2023-07-17 10:29:49 +00:00

Sign in to join this conversation.

No reviewers