[#129] client: Do not override error status WriteObject() #130

Merged

fyrchik merged 1 commit from fyrchik/frostfs-sdk-go:client-fix-transformer into master

2023-07-28 07:34:56 +00:00

fyrchik commented

2023-07-26 11:52:38 +00:00

Owner

Fix #129.

Here is a scenario:

resolveFrostFSErrors is false.
The first object part was not written, which was signified in status.
The second part was written correctly.

Client now thinks that the object is written even though it was not.
In theory we could also return only status, but client-side splitting
is not a single RPC, so it makes sense.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Fix #129. Here is a scenario: 1. `resolveFrostFSErrors` is false. 2. The first object part was not written, which was signified in status. 3. The second part was written correctly. Client now thinks that the object is written even though it was not. In theory we could also return only status, but client-side splitting is not a single RPC, so it makes sense. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik added 1 commit 2023-07-26 11:52:41 +00:00

[#129 ] client: Do not override error status WriteObject()

/ DCO (pull_request) Successful in 1m17s

Details

/ Lint (pull_request) Successful in 2m36s

Details

/ Tests (1.19) (pull_request) Successful in 2m14s

Details

/ Tests (1.20) (pull_request) Successful in 6m0s

Details

ecb1fef78c

Here is a scenario:
1. `resolveFrostFSErrors` is false.
2. The first object part was not written, which was signified in status.
3. The second part was written correctly.

Client now thinks that the object is written even though it was not.
In theory we could also return only status, but client-side splitting
is not a single RPC, so it makes sense.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>