TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 30 Pull requests 3 Releases Activity Actions

[#121] client: Make PrmContainerDelete fields public #141

Merged
fyrchik merged 3 commits from aarifullin/frostfs-sdk-go:master into master 2023-08-05 15:58:16 +00:00
Conversation 1 Commits 3 Files changed 3 +80 -52
aarifullin commented 2023-08-03 09:19:24 +00:00
Member
Copy link
  • Refactor client PrmContainerDelete usage witihn pool
  • Introduce WaitParams CheckValidity method
  • Add WaitParams.CheckValidity() check within containerPut because SetWaitParams is deprecated, but parameters were checked within this setter with checkForPositive()

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Refactor client PrmContainerDelete usage witihn pool * Introduce WaitParams CheckValidity method * Add WaitParams.CheckValidity() check within containerPut because SetWaitParams is deprecated, but parameters were checked within this setter with checkForPositive() Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added the
refactoring
 label 2023-08-03 09:19:24 +00:00
aarifullin added 2 commits 2023-08-03 09:19:25 +00:00 
Signed-off-by: Airat Arifullin a.arifullin@yadro.com
* Refactor client PrmContainerDelete usage
* Introduce WaitParams CheckValidity method

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin requested review from storage-core-developers 2023-08-03 09:19:54 +00:00
aarifullin requested review from storage-core-committers 2023-08-03 09:19:54 +00:00
aarifullin requested review from storage-services-developers 2023-08-03 09:19:54 +00:00
aarifullin force-pushed master from 0a1af05d85 to 3b7e556aa3 2023-08-03 10:01:28 +00:00 Compare
aarifullin force-pushed master from 3b7e556aa3 to 93281ffcf8 2023-08-03 10:27:02 +00:00 Compare
fyrchik reviewed 2023-08-03 10:59:43 +00:00
pool/pool.go
@ -505,3 +507,2 @@
if !prm.waitParamsSet {
prm.waitParams.setDefaults()
if prm.WaitParams == nil {
fyrchik commented 2023-08-03 10:59:43 +00:00
Owner
Copy link

Won't private fields be a problem here too?

Won't private fields be a problem here too?
aarifullin commented 2023-08-03 12:42:01 +00:00
Author
Member
Copy link

Sorry, I didn't get the point. prm.WaitParams is no longer private

Sorry, I didn't get the point. `prm.WaitParams` is no longer private
fyrchik commented 2023-08-03 12:45:29 +00:00
Owner
Copy link

Yes, but the WaitParams itself has private fields. I think making them public aligns well with the overall goal.

Yes, but the `WaitParams` itself has private fields. I think making them public aligns well with the overall goal.
aarifullin commented 2023-08-03 12:55:08 +00:00
Author
Member
Copy link

Oh. You're right. I'll fix it

Oh. You're right. I'll fix it
fyrchik marked this conversation as resolved
aarifullin force-pushed master from 93281ffcf8 to eca912607a 2023-08-03 13:02:40 +00:00 Compare
fyrchik commented 2023-08-03 13:15:08 +00:00
Owner
Copy link

@aarifullin linter warnings are correct (dots at the end of a sentence), let's not dismiss.

@aarifullin linter warnings are correct (dots at the end of a sentence), let's not dismiss.
fyrchik approved these changes 2023-08-03 13:15:14 +00:00
aarifullin force-pushed master from eca912607a to 0317938987 2023-08-04 07:24:16 +00:00 Compare
fyrchik requested review from storage-services-committers 2023-08-04 07:26:07 +00:00
alexvanin approved these changes 2023-08-04 07:58:47 +00:00
acid-ant approved these changes 2023-08-04 10:55:52 +00:00
fyrchik approved these changes 2023-08-05 15:58:09 +00:00
fyrchik merged commit 936e6d230b into master 2023-08-05 15:58:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#141
No description provided.
Delete branch "aarifullin/frostfs-sdk-go:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?