TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 34 Pull requests 2 Releases Activity Actions

Make PrmContainerEACL fields public #145

Merged
fyrchik merged 2 commits from aarifullin/frostfs-sdk-go:feature/121-prm_eacl into master 2023-08-16 09:53:52 +00:00
Conversation 0 Commits 2 Files changed 2 +18 -12
aarifullin commented 2023-08-11 08:09:40 +00:00
Member
Copy link

Airat Arifullin a.arifullin@yadro.com

Airat Arifullin <a.arifullin@yadro.com>
aarifullin added 1 commit 2023-08-11 08:09:42 +00:00 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin added the
refactoring
 label 2023-08-11 08:09:54 +00:00
aarifullin requested review from storage-core-developers 2023-08-11 08:10:09 +00:00
aarifullin requested review from storage-core-committers 2023-08-11 08:10:10 +00:00
aarifullin requested review from storage-services-committers 2023-08-11 08:10:48 +00:00
aarifullin requested review from storage-services-developers 2023-08-11 08:10:48 +00:00
acid-ant approved these changes 2023-08-11 08:14:33 +00:00
dkirillov reviewed 2023-08-11 11:10:47 +00:00
pool/pool.go Outdated
@ -2516,2 +2516,2 @@
if cnrID != nil {
prm.SetContainerID(*cnrID)
prm := PrmContainerEACL{
ContainerID: *cnrID,
dkirillov commented 2023-08-11 11:10:47 +00:00
Member
Copy link

It seems we have to check if cnrID isn't nil

It seems we have to check if `cnrID` isn't `nil`
aarifullin commented 2023-08-14 15:19:09 +00:00
Author
Member
Copy link

You're right. I ignored the check

You're right. I ignored the check
dkirillov marked this conversation as resolved
aarifullin force-pushed feature/121-prm_eacl from 20e40a6086 to a56d873077 2023-08-14 15:20:23 +00:00 Compare
dkirillov reviewed 2023-08-15 06:37:50 +00:00
pool/pool.go Outdated
@ -2516,2 +2517,3 @@
if cnrID != nil {
prm.SetContainerID(*cnrID)
prm = PrmContainerEACL{
ContainerID: *cnrID,
dkirillov commented 2023-08-15 06:37:50 +00:00
Member
Copy link

Not functional but why don't we write prm.ContainerID = *cnrID (we have already initialized prm above)?

Not functional but why don't we write `prm.ContainerID = *cnrID` (we have already initialized `prm` above)?
aarifullin commented 2023-08-16 09:39:06 +00:00
Author
Member
Copy link

Okay, fixed 👍

Okay, fixed 👍
fyrchik approved these changes 2023-08-15 06:39:12 +00:00
aarifullin force-pushed feature/121-prm_eacl from a56d873077 to 00355300f7 2023-08-16 09:38:58 +00:00 Compare
dstepanov-yadro approved these changes 2023-08-16 09:43:24 +00:00
ale64bit approved these changes 2023-08-16 09:44:28 +00:00
fyrchik approved these changes 2023-08-16 09:53:33 +00:00
fyrchik merged commit 6fdbe75517 into master 2023-08-16 09:53:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
ale64bit
fyrchik
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#145
No description provided.
Delete branch "aarifullin/frostfs-sdk-go:feature/121-prm_eacl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?