[#121] client: Make PrmObjectHash fields public #156

aarifullin · 2023-09-04T09:45:31Z

aarifullin commented

2023-09-04 09:45:31 +00:00

Introduce buildRequest for PrmObjectHash

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Introduce buildRequest for PrmObjectHash Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

aarifullin added the

refactoring

label 2023-09-04 09:45:31 +00:00

aarifullin requested review from storage-core-committers 2023-09-04 09:45:44 +00:00

aarifullin requested review from storage-core-developers 2023-09-04 09:45:45 +00:00

aarifullin requested review from storage-services-committers 2023-09-04 09:45:47 +00:00

aarifullin requested review from storage-services-developers 2023-09-04 09:45:53 +00:00

aarifullin force-pushed feature/121-prm_object_hash from 3c95ad6f97 to 40dcfa8331

2023-09-04 09:58:27 +00:00

Compare

acid-ant approved these changes 2023-09-04 10:26:57 +00:00

aarifullin force-pushed feature/121-prm_object_hash from 40dcfa8331 to f67d526d01

2023-09-04 10:49:30 +00:00

Compare

aarifullin requested review from acid-ant 2023-09-04 10:49:37 +00:00

aarifullin force-pushed feature/121-prm_object_hash from f67d526d01 to 0f7c47d26f

2023-09-04 13:19:18 +00:00

Compare

fyrchik reviewed 2023-09-04 14:15:23 +00:00

client/object_hash.go Outdated

													
				@ -22,0 +24,4 @@

					Length uint64

				}

				type ChecksumType v2refs.ChecksumType

fyrchik commented

2023-09-04 14:15:09 +00:00

This doesn't seem to be related to the refactoring, does it?

aarifullin commented

2023-09-04 14:44:19 +00:00

Poster

You are right. But I think PrmObjectHash should not have v2refs field. That's why I have introduced this type (the field was initialized with TillichZemorAlgo() method)

You are right. But I think `PrmObjectHash` should not have `v2refs` field. That's why I have introduced this type (the field was initialized with `TillichZemorAlgo()` method)

fyrchik commented

2023-09-05 11:10:29 +00:00

How about checksum package in this repo?
We also have object.Range already.

How about `checksum` package in this repo? We also have `object.Range` already.

aarifullin commented

2023-09-05 12:39:47 +00:00

Poster

Alright. I will reuse Range and Checksum

aarifullin commented

2023-09-05 13:41:16 +00:00

Poster

Fixed