TrueCloudLab/frostfs-sdk-go
30
0
Fork 20
Code Issues 30 Pull requests 1 Releases Activity Actions

Remove math.rand/Read #161

Merged
fyrchik merged 1 commit from fyrchik/frostfs-sdk-go:fix-mathrand into master 2024-09-04 19:51:15 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
fyrchik commented 2023-09-08 14:16:56 +00:00
Owner
Copy link
No description provided.
fyrchik force-pushed fix-mathrand from 9b12c3d02e to 8bc64e088e 2023-09-08 14:17:14 +00:00 Compare
acid-ant approved these changes 2023-09-11 06:26:14 +00:00
aarifullin approved these changes 2023-09-11 07:36:42 +00:00
alexvanin approved these changes 2023-09-11 08:30:32 +00:00
alexvanin left a comment
Owner
Copy link

thought: In theory it might affect some tests in node, that expects predictable values, so I would check it.

**thought:** _In theory_ it might affect some tests in node, that expects predictable values, so I would check it.
👍 1
fyrchik merged commit 8bc64e088e into master 2023-09-11 11:30:51 +00:00
fyrchik referenced this pull request from a commit 2023-09-11 11:30:51 +00:00
[#161] *: Do not use math/rand.Read()
fyrchik deleted branch fix-mathrand 2023-09-11 11:30:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#161
No description provided.
Delete branch "fyrchik/frostfs-sdk-go:fix-mathrand"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?