TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

[#88] min aggregator bug fixed, tests added #164

Merged
fyrchik merged 2 commits from AndrewDanilin/frostfs-sdk-go:88-fix_min_aggregator_and_add_tests_for_them into master 2023-10-03 07:05:04 +00:00
Conversation 3 Commits 2 Files changed 3 +57 -6
AndrewDanilin commented 2023-09-12 18:29:59 +00:00
Contributor
Copy link
No description provided.
acid-ant commented 2023-09-15 06:01:10 +00:00
Member
Copy link

It is a common practice to write commit message imperatively. Could you add a commit sign-off like a Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com> - we have CI step which is failed.
Details here https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/actions/runs/327/jobs/0

It is a common practice to write commit message imperatively. Could you add a commit sign-off like a `Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>` - we have CI step which is failed. Details here https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/actions/runs/327/jobs/0
👍 1
AndrewDanilin force-pushed 88-fix_min_aggregator_and_add_tests_for_them from 820a301172 to b8a0444ddd 2023-09-15 11:25:58 +00:00 Compare
AndrewDanilin commented 2023-09-15 11:33:07 +00:00
Author
Contributor
Copy link

Done!

> Done!
AndrewDanilin changed title from WIP: [#88] min aggregator bug fixed, tests added to [#88] min aggregator bug fixed, tests added 2023-09-15 16:32:03 +00:00
AndrewDanilin changed title from [#88] min aggregator bug fixed, tests added to [#88] min aggregator bug fixed, tests added 2023-09-15 16:32:39 +00:00
fyrchik requested changes 2023-09-15 16:49:42 +00:00
fyrchik left a comment
Owner
Copy link
  1. Tests are failing, please take a look at CI
  2. Could you prefix the commit with netmap: -- like others in this repo, this would make looking at history much easier.
1. Tests are failing, please take a look at CI 2. Could you prefix the commit with `netmap: ` -- like others in this repo, this would make looking at history much easier.
netmap/aggregator.go Outdated
@ -24,3 +24,3 @@
minAgg struct {
min float64
min *float64
fyrchik commented 2023-09-15 16:48:56 +00:00
Owner
Copy link

What about having a bool field like minFound bool? (with a meaning minFound == true if and only if a.min != nil in the current implementation.
Your solution is correct, however it allocates (didn't check, but it should). We execute this routine on every operation with an object, so no allocations would be nice here.

What about having a bool field like `minFound bool`? (with a meaning `minFound == true` if and only if `a.min != nil` in the current implementation. Your solution is correct, however it allocates (didn't check, but it should). We execute this routine on every operation with an object, so no allocations would be nice here.
AndrewDanilin commented 2023-09-16 13:37:33 +00:00
Author
Contributor
Copy link

Good advice, I'll change it.

Good advice, I'll change it.
fyrchik commented 2023-09-15 16:50:14 +00:00
Owner
Copy link

Also, commit message should start with an imperative: not ... fixed, but fix ...

Also, commit message should start with an imperative: not `... fixed`, but `fix ...`
fyrchik requested review from storage-core-committers 2023-09-15 16:54:58 +00:00
fyrchik requested review from storage-core-developers 2023-09-15 16:54:59 +00:00
fyrchik requested review from storage-services-committers 2023-09-15 16:55:00 +00:00
fyrchik requested review from storage-services-developers 2023-09-15 16:55:00 +00:00
AndrewDanilin force-pushed 88-fix_min_aggregator_and_add_tests_for_them from b8a0444ddd to c8d82dae38 2023-09-16 13:56:42 +00:00 Compare
AndrewDanilin force-pushed 88-fix_min_aggregator_and_add_tests_for_them from c8d82dae38 to 5f8e9917ee 2023-09-16 14:00:28 +00:00 Compare
AndrewDanilin force-pushed 88-fix_min_aggregator_and_add_tests_for_them from c352ec1c93 to 5e51e7dcae 2023-09-16 14:17:39 +00:00 Compare
AndrewDanilin force-pushed 88-fix_min_aggregator_and_add_tests_for_them from 5e51e7dcae to c0780510aa 2023-09-16 14:33:55 +00:00 Compare
aarifullin approved these changes 2023-09-19 08:49:20 +00:00
AndrewDanilin requested review from fyrchik 2023-09-21 12:33:00 +00:00
fyrchik approved these changes 2023-10-02 12:57:15 +00:00
acid-ant approved these changes 2023-10-02 13:06:24 +00:00
fyrchik merged commit d71a0e0755 into master 2023-10-03 07:05:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
acid-ant
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#164
No description provided.
Delete branch "AndrewDanilin/frostfs-sdk-go:88-fix_min_aggregator_and_add_tests_for_them"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?