pool: Close inner pools during close routine #169

Merged

alexvanin merged 1 commits from alexvanin/frostfs-sdk-go:fix/pool-close into master

2023-09-20 10:19:44 +00:00

alexvanin commented

2023-09-20 09:15:58 +00:00

Owner

Some apps do not reuse pool instance and expect that pool.Close() free resources. But it didn't actually
close inner SDK clients, so it leads to goroutine leak in storage.

Some apps do not reuse pool instance and expect that `pool.Close()` free resources. But it didn't actually close inner SDK clients, so it leads to goroutine leak in storage.

alexvanin added the

label 2023-09-20 09:15:58 +00:00

alexvanin force-pushed fix/pool-close from 64565c43b6 to 99c273f499

2023-09-20 09:16:25 +00:00

Compare

alexvanin requested review from dstepanov-yadro 2023-09-20 09:20:48 +00:00

alexvanin requested review from dkirillov 2023-09-20 09:20:48 +00:00

alexvanin requested review from pogpp 2023-09-20 09:20:48 +00:00

alexvanin requested review from ironbee 2023-09-20 09:20:48 +00:00

alexvanin requested review from mbiryukova 2023-09-20 09:20:49 +00:00

alexvanin requested review from r.loginov 2023-09-20 09:20:49 +00:00

dkirillov approved these changes 2023-09-20 09:41:30 +00:00

dstepanov-yadro approved these changes 2023-09-20 09:44:20 +00:00

acid-ant approved these changes 2023-09-20 10:11:33 +00:00

alexvanin merged commit 99c273f499 into master

2023-09-20 10:19:44 +00:00

alexvanin deleted branch fix/pool-close

2023-09-20 10:19:44 +00:00

alexvanin referenced this issue from a commit

2023-09-20 10:19:46 +00:00

[#169] pool: Close inner pools during close routine

Sign in to join this conversation.

No reviewers

No Label

good first issue

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#169

There is no content yet.