[#191] limit_tree_pool_retries #191

Merged
alexvanin merged 2 commits from poc/limit_tree_pool_retries into master 2024-09-04 19:51:15 +00:00
Member
No description provided.
dkirillov self-assigned this 2023-11-07 07:30:59 +00:00
dkirillov changed title from WIP: poc/limit_tree_pool_retries to WIP: [#191] limit_tree_pool_retries 2023-11-07 07:31:20 +00:00
dkirillov force-pushed poc/limit_tree_pool_retries from dd96a3ee32 to 3ead96fa3a 2023-11-07 07:37:55 +00:00 Compare
dkirillov force-pushed poc/limit_tree_pool_retries from 3ead96fa3a to 9c5d3aedcc 2023-11-07 07:40:12 +00:00 Compare
dkirillov changed title from WIP: [#191] limit_tree_pool_retries to [#191] limit_tree_pool_retries 2023-11-07 07:44:16 +00:00
dkirillov requested review from storage-services-committers 2023-11-07 07:44:26 +00:00
dkirillov requested review from storage-services-developers 2023-11-07 07:44:26 +00:00
fyrchik reviewed 2023-11-07 08:48:21 +00:00
@ -794,0 +824,4 @@
type reqKeyType string
const reqIDKey = reqKeyType("request_id")
Owner

For single-value context keys we can use typed empty struct type reqKeyType struct{}
I belive it is faster, because we don't need to compare string values
Go compiler uses this appoach a lot, e.g. 9d836d41d0/src/net/lookup.go (L312)

For single-value context keys we can use typed empty struct `type reqKeyType struct{}` I belive it is faster, because we don't need to compare string values Go compiler uses this appoach a lot, e.g. https://github.com/golang/go/blob/9d836d41d0d9df3acabf7f9607d3b09188a9bfc6/src/net/lookup.go#L312
fyrchik marked this conversation as resolved
fyrchik requested review from storage-core-committers 2023-11-07 08:48:30 +00:00
fyrchik requested review from storage-core-developers 2023-11-07 08:48:31 +00:00
dkirillov force-pushed poc/limit_tree_pool_retries from 9c5d3aedcc to 3b0871fba6 2023-11-07 09:50:48 +00:00 Compare
dstepanov-yadro approved these changes 2023-11-07 10:12:26 +00:00
fyrchik approved these changes 2023-11-07 10:25:08 +00:00
@ -794,0 +824,4 @@
type reqKeyType struct{}
func SetRequestID(ctx context.Context, reqID string) context.Context {
Owner

How about WithRequestID (similar to WithValue)?

How about `WithRequestID` (similar to `WithValue`)?
Owner

And if it is public we need some comments about what it affects.

And if it is public we need some comments about what it affects.
Author
Member

How about WithRequestID (similar to WithValue)?

I would prefer to have paired names GetRequestID/SetRequestID

> How about `WithRequestID` (similar to `WithValue`)? I would prefer to have paired names `GetRequestID`/`SetRequestID`
dkirillov force-pushed poc/limit_tree_pool_retries from 3b0871fba6 to ab75edd709 2023-11-07 11:46:03 +00:00 Compare
fyrchik approved these changes 2023-11-07 12:12:00 +00:00
acid-ant approved these changes 2023-11-07 13:11:10 +00:00
alexvanin approved these changes 2023-11-08 06:31:35 +00:00
alexvanin merged commit ab75edd709 into master 2023-11-08 06:31:40 +00:00
alexvanin deleted branch poc/limit_tree_pool_retries 2023-11-08 06:31:41 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-services-developers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#191
No description provided.