TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 29 Pull requests 2 Releases Activity Actions

[#166] netmap: tests moved from JSON to YML #192

Merged
fyrchik merged 1 commit from achuprov/frostfs-sdk-go:yml_tests into master 2024-09-04 19:51:15 +00:00
Conversation 2 Commits 1 Files changed 3 +180 -15
achuprov commented 2023-11-13 07:52:38 +00:00
Member
Copy link

Close: #166

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close: #166 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov force-pushed yml_tests from 300f659b12 to db614e4908 2023-11-13 09:17:53 +00:00 Compare
achuprov force-pushed yml_tests from db614e4908 to f97530c3d8 2023-11-13 09:37:53 +00:00 Compare
achuprov changed title from WIP: [#166] netmap: tests moved from JSON to YML to [#166] netmap: tests moved from JSON to YML 2023-11-13 09:40:49 +00:00
achuprov requested review from storage-core-committers 2023-11-13 09:41:12 +00:00
achuprov requested review from storage-core-developers 2023-11-13 09:41:18 +00:00
aarifullin approved these changes 2023-11-13 11:46:43 +00:00
dstepanov-yadro reviewed 2023-11-13 12:57:32 +00:00
netmap/json_test.go Outdated
@ -40,3 +60,3 @@
func TestPlacementPolicy_Interopability(t *testing.T) {
const testsDir = "./json_tests"
const testsDir = "./yml_tests"
dstepanov-yadro commented 2023-11-13 12:57:30 +00:00
Member
Copy link

So file should be named natmap/yml_test.go ?

So file should be named `natmap/yml_test.go` ?
dstepanov-yadro commented 2023-11-15 08:29:51 +00:00
Member
Copy link

or test_marshal.go?

or `test_marshal.go`?
dstepanov-yadro marked this conversation as resolved
acid-ant commented 2023-11-13 14:56:23 +00:00
Member
Copy link

Commits have the same descriptions. Can you describe a bit more what was done in scope each of them?

Commits have the same descriptions. Can you describe a bit more what was done in scope each of them?
acid-ant reviewed 2023-11-13 15:13:16 +00:00
netmap/json_test.go Outdated
@ -163,2 +183,4 @@
}
}
type tempPlacementPolicy struct {
acid-ant commented 2023-11-13 15:13:06 +00:00
Member
Copy link

Maybe it is better to move all the structs/func related to yml to separate file or renamed this one?

Maybe it is better to move all the structs/func related to `yml` to separate file or renamed this one?
achuprov force-pushed yml_tests from f97530c3d8 to 80207ab7df 2023-11-15 08:59:45 +00:00 Compare
achuprov force-pushed yml_tests from 80207ab7df to a05ee97158 2023-11-15 09:05:42 +00:00 Compare
dstepanov-yadro approved these changes 2023-11-15 09:12:27 +00:00
aarifullin approved these changes 2023-11-15 09:14:32 +00:00
acid-ant approved these changes 2023-11-15 10:43:13 +00:00
netmap/yml_unmarshal.go Outdated
@ -0,0 +45,4 @@
func convertStringToOperation(opStr string) netmap.Operation {
switch strings.ToUpper(opStr) {
case "EQ":
acid-ant commented 2023-11-15 10:42:13 +00:00
Member
Copy link

How about to initialize map out of the function and just take the value from it?

How about to initialize map out of the function and just take the value from it?
fyrchik reviewed 2023-11-16 09:00:26 +00:00
netmap/yml_tests/filter_complex.yml Outdated
@ -0,0 +39,4 @@
value: ''
filters:
- name: StorageSSD
key: ''
fyrchik commented 2023-11-16 09:00:11 +00:00
Owner
Copy link

Can empty values be omitted?

Can empty values be omitted?
fyrchik commented 2023-11-16 09:00:12 +00:00
Owner
Copy link

Can empty values be omitted?

Can empty values be omitted?
achuprov commented 2023-11-16 12:32:07 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik marked this conversation as resolved
fyrchik approved these changes 2023-11-16 09:00:42 +00:00
achuprov force-pushed yml_tests from a05ee97158 to 828009e204 2023-11-16 12:17:00 +00:00 Compare
fyrchik approved these changes 2023-11-17 07:57:00 +00:00
fyrchik commented 2023-11-17 07:57:38 +00:00
Owner
Copy link

Comments should start with a verb in imperative: tests moved -> Move tests.

Comments should start with a verb in imperative: `tests moved` -> `Move tests`.
achuprov force-pushed yml_tests from 828009e204 to 03d35dd1f3 2023-11-17 11:43:32 +00:00 Compare
fyrchik merged commit 03d35dd1f3 into master 2023-11-17 11:48:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
aarifullin
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#192
No description provided.
Delete branch "achuprov/frostfs-sdk-go:yml_tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?