TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

Pass user.ID by value #195

Merged
fyrchik merged 2 commits from dstepanov-yadro/frostfs-sdk-go:feat/user-id into master 2024-09-04 19:51:15 +00:00
Conversation 0 Commits 2 Files changed 27 +70 -60
dstepanov-yadro commented 2023-11-21 08:36:14 +00:00
Member
Copy link

Relates #190

Relates #190
dstepanov-yadro requested review from storage-core-committers 2023-11-21 08:41:13 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-11-21 08:41:14 +00:00
aarifullin approved these changes 2023-11-21 09:38:18 +00:00
fyrchik approved these changes 2023-11-21 09:49:35 +00:00
object/object.go Outdated
@ -623,3 +623,2 @@
var errOIDNotSet = errors.New("object ID is not set")
var errCIDNotSet = errors.New("container ID is not set")
var (
fyrchik commented 2023-11-21 09:49:29 +00:00
Owner
Copy link

separate commit?

separate commit?
dstepanov-yadro commented 2023-11-21 09:58:44 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/user-id from f0b4d0d995 to f67ac45b6a 2023-11-21 09:58:33 +00:00 Compare
dstepanov-yadro requested review from fyrchik 2023-11-21 10:44:25 +00:00
fyrchik approved these changes 2023-11-21 13:38:49 +00:00
dstepanov-yadro requested review from aarifullin 2023-11-21 13:40:45 +00:00
acid-ant reviewed 2023-11-22 08:01:42 +00:00
object/object.go Outdated
@ -203,3 +203,2 @@
// OwnerID returns identifier of the object owner.
func (o *Object) OwnerID() *user.ID {
// OwnerID returns identifier of the object owner and True, if ownerID is set and valid.
acid-ant commented 2023-11-22 08:01:42 +00:00
Member
Copy link

and True, if ownerID is set and valid.

Looks redundant or it is about something different?

> and True, if ownerID is set and valid. Looks redundant or it is about something different?
dstepanov-yadro commented 2023-11-22 16:21:46 +00:00
Author
Member
Copy link

fixed

fixed
acid-ant marked this conversation as resolved
acid-ant approved these changes 2023-11-22 08:02:17 +00:00
dstepanov-yadro force-pushed feat/user-id from f67ac45b6a to 56debcfa56 2023-11-22 16:21:42 +00:00 Compare
fyrchik merged commit 56debcfa56 into master 2023-11-22 16:25:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#195
No description provided.
Delete branch "dstepanov-yadro/frostfs-sdk-go:feat/user-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?