TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

object/user: Add ScriptHash method #199

Merged
fyrchik merged 1 commit from achuprov/frostfs-sdk-go:feature/198_add_ScriptHash into master 2024-01-26 14:10:13 +00:00
Conversation 0 Commits 1 Files changed 2 +19
achuprov commented 2024-01-17 11:01:04 +00:00
Member
Copy link

Close #198

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #198 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
fyrchik reviewed 2024-01-17 11:07:01 +00:00
user/id.go Outdated
@ -126,0 +126,4 @@
// ScriptHash calculates and returns script hash of ID.
func (x *ID) ScriptHash() (util.Uint160, error) {
ownerAddress := x.EncodeToString()
fyrchik commented 2024-01-17 11:06:59 +00:00
Owner
Copy link

This implementation was just an example, we could do it more optimally (see SetScriptHash implementation)
Here we unnecessarily do encode-decode cycle.

This implementation was just an example, we could do it more optimally (see `SetScriptHash` implementation) Here we unnecessarily do encode-decode cycle.
achuprov commented 2024-01-17 15:30:45 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
user/id_test.go Outdated
@ -96,3 +97,3 @@
s := id.EncodeToString()
_, err := base58.Decode(s)
_, err := base58.CheckDecode(s)
fyrchik commented 2024-01-17 11:06:04 +00:00
Owner
Copy link

How is this change related to the commit?

How is this change related to the commit?
achuprov commented 2024-01-17 15:30:54 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik commented 2024-01-17 18:28:41 +00:00
Owner
Copy link

The change wasn't bad, we could just move it to separate commit
But not the goal, anyway.

The change wasn't bad, we could just move it to separate commit But not the goal, anyway.
fyrchik marked this conversation as resolved
achuprov force-pushed feature/198_add_ScriptHash from b7d7dce14d to 7ec38a7c80 2024-01-17 14:11:34 +00:00 Compare
achuprov force-pushed feature/198_add_ScriptHash from 7ec38a7c80 to 0075d9d807 2024-01-17 14:27:43 +00:00 Compare
achuprov requested review from storage-core-committers 2024-01-17 14:54:44 +00:00
achuprov requested review from storage-core-developers 2024-01-17 14:54:47 +00:00
fyrchik approved these changes 2024-01-17 18:31:12 +00:00
user/id.go Outdated
@ -75,0 +79,4 @@
}
var scriptHash util.Uint160
copy(scriptHash[:], x.w[1:21])
fyrchik commented 2024-01-17 18:31:00 +00:00
Owner
Copy link

It is better to use decoders from https://github.com/nspcc-dev/neo-go/blob/master/pkg/util/uint160.go
There are LE+BE representations, and we use BytesBE() in SetScriptHash().
So if neo-go are to change the internal representation, this code will break. The one with Uint160DecodeBytesBE will not.

It is better to use decoders from https://github.com/nspcc-dev/neo-go/blob/master/pkg/util/uint160.go There are LE+BE representations, and we use `BytesBE()` in `SetScriptHash()`. So if neo-go are to change the internal representation, this code will break. The one with `Uint160DecodeBytesBE` will not.
achuprov commented 2024-01-26 10:28:49 +00:00
Author
Member
Copy link

fixed

fixed
achuprov force-pushed feature/198_add_ScriptHash from 0075d9d807 to 23666ef311 2024-01-26 10:27:33 +00:00 Compare
fyrchik reviewed 2024-01-26 10:30:33 +00:00
user/id_test.go Outdated
@ -50,0 +59,4 @@
decodedScriptHash, err := address.StringToUint160(ownerAddress)
require.NoError(t, err)
require.True(t, reflect.DeepEqual(scriptHash, decodedScriptHash))
fyrchik commented 2024-01-26 10:30:29 +00:00
Owner
Copy link

scriptHash.Equals?

`scriptHash.Equals`?
achuprov force-pushed feature/198_add_ScriptHash from 23666ef311 to b0190b809c 2024-01-26 11:42:08 +00:00 Compare
fyrchik approved these changes 2024-01-26 14:09:23 +00:00
fyrchik merged commit 65b4525b3b into master 2024-01-26 14:10:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#199
No description provided.
Delete branch "achuprov/frostfs-sdk-go:feature/198_add_ScriptHash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?