netmap: Fix string escape in PlacementPolicy.String() #207

fyrchik · 2024-03-01T14:30:43Z

fyrchik commented

2024-03-01 14:30:43 +00:00

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

dkirillov referenced this pull request from TrueCloudLab/frostfs-s3-gw

2024-03-01 14:32:32 +00:00

bugfix/session_for_container_read #326

fyrchik requested review from storage-core-committers 2024-03-01 14:34:28 +00:00

fyrchik requested review from storage-core-developers 2024-03-01 14:34:28 +00:00

fyrchik force-pushed fix-parser from 4eea81fe56 to 083cc88a43

2024-03-01 14:35:21 +00:00

Compare

fyrchik reviewed 2024-03-01 14:39:41 +00:00

netmap/policy.go

					
				@ -945,2 +946,3 @@

				func escapeString(s string) string {

					if strings.ContainsAny(s, " -\t") {

					for _, r := range s {

						if 'a' <= r && r <= 'z' || 'A' <= r && r <= 'Z' || '0' <= r && r <= '9' || r == '_' {

fyrchik commented

2024-03-01 14:39:41 +00:00

I have benchmarked strings.ContainsAny, regexp and this.
regexp was twice as slow
strings.ContainsAny was less readable (good luck counting symbols)
this is maintainable and obvious

I have benchmarked `strings.ContainsAny`, regexp and this. regexp was twice as slow strings.ContainsAny was less readable (good luck counting symbols) this is maintainable and obvious