TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 2 Releases Activity Actions 2

[#226] pool/tree: Fix handling access denied error #226

Merged
dkirillov merged 1 commit from dkirillov/frostfs-sdk-go:bugfix/pool_drop_access_denied_retry into master 2024-05-31 07:43:21 +00:00
Conversation 2 Commits 1 Files changed 2 +6 -1
dkirillov commented 2024-05-30 11:59:17 +00:00
Member
Copy link

Signed-off-by: Denis Kirillov d.kirillov@yadro.com

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov self-assigned this 2024-05-30 11:59:17 +00:00
dkirillov changed title from WIP: [#XX] pool/tree: Fix handling access denied error to WIP: [#226] pool/tree: Fix handling access denied error 2024-05-30 11:59:28 +00:00
dkirillov force-pushed bugfix/pool_drop_access_denied_retry from f1995db70a to 6a52487edd 2024-05-30 11:59:50 +00:00 Compare
dkirillov changed title from WIP: [#226] pool/tree: Fix handling access denied error to [#226] pool/tree: Fix handling access denied error 2024-05-30 14:26:15 +00:00
dkirillov requested review from storage-core-committers 2024-05-30 14:26:26 +00:00
dkirillov requested review from storage-core-developers 2024-05-30 14:26:29 +00:00
dkirillov requested review from storage-sdk-committers 2024-05-30 14:26:29 +00:00
dkirillov requested review from storage-sdk-developers 2024-05-30 14:26:30 +00:00
dkirillov requested review from storage-services-committers 2024-05-30 14:26:31 +00:00
dkirillov requested review from storage-services-developers 2024-05-30 14:26:31 +00:00
ironbee approved these changes 2024-05-30 14:28:57 +00:00
pogpp approved these changes 2024-05-30 14:29:34 +00:00
alexvanin commented 2024-05-30 14:29:50 +00:00
Owner
Copy link

@dkirillov
Can you provide error message we are matching with denied but not is denied by?
Should we create an issue to use specific error codes to avoid string matching? Maybe there is an issue already?

@dkirillov Can you provide error message we are matching with `denied` but not `is denied by`? Should we create an issue to use specific error codes to avoid string matching? Maybe there is an issue already?
aarifullin approved these changes 2024-05-30 14:52:51 +00:00
dkirillov commented 2024-05-30 14:52:55 +00:00
Author
Member
Copy link

Can you provide error message we are matching with denied but not is denied by?

rpc error: code = Unknown desc = status: code = 2048 message = access to object operation denied

Should we create an issue to use specific error codes to avoid string matching

Probably yes, but I'm not sure if we don't forget mention all accessDenied error types (strings.Contains also has some problem though)

> Can you provide error message we are matching with denied but not is denied by? `rpc error: code = Unknown desc = status: code = 2048 message = access to object operation denied` > Should we create an issue to use specific error codes to avoid string matching Probably yes, but I'm not sure if we don't forget mention all accessDenied error types (`strings.Contains` also has some problem though)
dkirillov merged commit 6a52487edd into master 2024-05-31 07:43:21 +00:00
dkirillov deleted branch bugfix/pool_drop_access_denied_retry 2024-05-31 07:43:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ironbee
pogpp
aarifullin
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-sdk-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#226
No description provided.
Delete branch "dkirillov/frostfs-sdk-go:bugfix/pool_drop_access_denied_retry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?