TrueCloudLab/frostfs-sdk-go
30
0
Fork 20
Code Issues 30 Pull requests 2 Releases Activity Actions

WIP: Introduce object patcher in client #248

Closed
aarifullin wants to merge 2 commits from feat/patch_cli into master
pull from: feat/patch_cli
merge into: TrueCloudLab:master
Conversation 1 Commits 2 Files changed 3 +352
aarifullin commented 2024-08-05 13:34:19 +00:00
Member
Copy link
  • object: Introduce SplitByMaxChunkLength method
  • client: Introduce object patcher
- object: Introduce `SplitByMaxChunkLength` method - client: Introduce object patcher
aarifullin added 2 commits 2024-08-05 13:34:28 +00:00 
* Add unit-test to test `SplitByMaxChunkLength`.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
[#XX] client: Introduce object patcher
Some checks failed
DCO / DCO (pull_request) Failing after 55s
Details
Tests and linters / Lint (pull_request) Failing after 59s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 1m2s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m4s
Details
8bf00a701b 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin force-pushed feat/patch_cli from 8bf00a701b to c40dbd0810 2024-08-05 13:34:49 +00:00 Compare
fyrchik reviewed 2024-08-05 13:43:58 +00:00
client/object_patch.go Outdated
@ -0,0 +24,4 @@
//
// Must be initialized using Client.ObjectPatchInit, any other
// usage is unsafe.
type ObjectPatcher interface {
fyrchik commented 2024-08-05 13:43:58 +00:00
Owner
Copy link

What is the purpose of this interface?
Patch is just another method, similar to PUT.

What is the purpose of this interface? `Patch` is just another method, similar to PUT.
aarifullin commented 2024-08-05 14:02:32 +00:00
Author
Member
Copy link

Your point is right - there is no any practical use of this interface right now (like we don't use to mock it in unit-tests and so). However, I was looking through Put implementation and came up with idea that client's patcher will need some decoration for patcher in the future - so, that was my assumption. If it's really unreasonable, I'll get it away

Your point is right - there is no any practical use of this interface right now (like we don't use to mock it in unit-tests and so). However, I was looking through `Put` implementation and came up with idea that client's patcher will need some decoration for `patcher` in the future - so, that was my assumption. If it's really unreasonable, I'll get it away
aarifullin requested review from storage-core-committers 2024-08-05 13:57:35 +00:00
aarifullin requested review from storage-core-developers 2024-08-05 13:57:35 +00:00
aarifullin requested review from storage-services-committers 2024-08-05 13:57:35 +00:00
aarifullin requested review from storage-services-developers 2024-08-05 13:57:36 +00:00
aarifullin force-pushed feat/patch_cli from c40dbd0810 to 00547bc32d 2024-08-05 14:04:01 +00:00 Compare
aarifullin changed title from Introduce object patcher in `client` to WIP: Introduce object patcher in `client` 2024-08-05 15:41:13 +00:00
aarifullin commented 2024-08-05 20:21:19 +00:00
Author
Member
Copy link

Sorry, occaionally created this PR from origin stream branch

Sorry, occaionally created this PR from origin stream branch
aarifullin closed this pull request 2024-08-05 20:21:22 +00:00
aarifullin deleted branch feat/patch_cli 2024-08-05 20:21:33 +00:00
All checks were successful
DCO / DCO (pull_request) Successful in 51s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m0s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 58s
Details
Tests and linters / Lint (pull_request) Successful in 2m2s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
TrueCloudLab/storage-core-committers
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#248
No description provided.
Delete branch "feat/patch_cli"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?