[#254] pool: Add parameter gracefulCloseOnSwitchTimeout #255

dkirillov · 2024-08-19T14:55:18Z

dkirillov commented

2024-08-19 14:55:18 +00:00

Add new param for waiting a little until current in-flight requests will be finished

close #254

Add new param for waiting a little until current in-flight requests will be finished close #254

dkirillov self-assigned this 2024-08-19 14:55:18 +00:00

dkirillov added 1 commit 2024-08-19 14:55:22 +00:00

[#254 ] pool: Add parameter gracefulCloseOnSwitchTimeout

DCO / DCO (pull_request) Successful in 37s

Details

Tests and linters / Tests (1.21) (pull_request) Successful in 53s

Details

Tests and linters / Tests (1.22) (pull_request) Successful in 54s

Details

Tests and linters / Lint (pull_request) Successful in 1m38s

Details

c416a37ce1

Add new param for waiting a little until current in-flight requests will be finished

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>

fyrchik reviewed 2024-08-19 14:57:48 +00:00

pool/pool.go

					
				@ -1229,0 +1248,4 @@

						return

					}

					time.AfterFunc(c.prm.gracefulCloseOnSwitchTimeout, func() {

fyrchik commented

2024-08-19 14:57:46 +00:00

Could you explain how this works?
So instead of closing immediately, we close after some time.
Why no new requests could arrive in the meantime?

Could you explain how this works? So instead of closing immediately, we close after some time. Why no new requests could arrive in the meantime?

dkirillov commented

2024-08-20 06:08:00 +00:00

At this time current client marked as unhealhty, so new request don't use this connection. Also after invoking such delayed close we invoke new dial, so client will contain brand new connection (despite the old one hasn't yet been closed)

fyrchik commented

2024-08-20 07:04:25 +00:00

Can this timeout affect switching logic?
e.g. we mark some endpoint as unhealthy, then switch back to it, but this switch timeout is lower than the graceful timeout here.

Can this timeout affect switching logic? e.g. we mark some endpoint as unhealthy, then switch back to it, but this switch timeout is lower than the graceful timeout here.

dkirillov commented

2024-08-20 08:10:35 +00:00

This timeout isn't affect swtitching logic because when we switch back we invoke dial and get new connection.

This timeout isn't affect swtitching logic because when we switch back we invoke `dial` and get new connection.